[syntax-errors] Detect single starred expression assignment x = *y (#17624)

## Summary

Part of #17412

Starred expressions cannot be used as values in assignment expressions.
Add a new semantic syntax error to catch such instances.
Note that we already have
`ParseErrorType::InvalidStarredExpressionUsage` to catch some starred
expression errors during parsing, but that does not cover top level
assignment expressions.

## Test Plan

- Added new inline tests for the new rule
- Found some examples marked as "valid" in existing tests (`_ = *data`),
which are not really valid (per this new rule) and updated them
- There was an existing inline test - `assign_stmt_invalid_value_expr`
which had instances of `*` expression which would be deemed invalid by
this new rule. Converted these to tuples, so that they do not trigger
this new rule.

Author: abhijeetbodas2001

crates/ruff_python_parser/resources/inline/err/assign_stmt_invalid_value_expr.py

@@ -1,5 +1,5 @@
-x = *a and b
-x = *yield x
-x = *yield from x
-x = *lambda x: x
+x = (*a and b,)
+x = (42, *yield x)
+x = (42, *yield from x)
+x = (*lambda x: x,)
 x = x := 1

crates/ruff_python_parser/resources/inline/err/assign_stmt_starred_expr_value.py

@@ -0,0 +1,4 @@
+_ = *[42]
+_ = *{42}
+_ = *list()
+_ = *(p + q)

crates/ruff_python_parser/resources/inline/ok/assign_stmt_starred_expr_value.py

@@ -0,0 +1,4 @@
+_ = 4
+_ = [4]
+_ = (*[1],)
+_ = *[1],

crates/ruff_python_parser/resources/valid/statement/assignment.py

@@ -37,7 +37,7 @@
 
 foo = 42
 
-[] = *data
-() = *data
+[] = (*data,)
+() = (*data,)
 a, b = ab
 a = b = c

crates/ruff_python_parser/src/parser/statement.rs

@@ -1127,10 +1127,10 @@ impl<'src> Parser<'src> {
         // a + b
 
         // test_err assign_stmt_invalid_value_expr
-        // x = *a and b
-        // x = *yield x
-        // x = *yield from x
-        // x = *lambda x: x
+        // x = (*a and b,)
+        // x = (42, *yield x)
+        // x = (42, *yield from x)
+        // x = (*lambda x: x,)
         // x = x := 1
 
         let mut value =

crates/ruff_python_parser/src/semantic_errors.rs

@@ -90,7 +90,7 @@ impl SemanticSyntaxChecker {
                     Self::duplicate_type_parameter_name(type_params, ctx);
                 }
             }
-            Stmt::Assign(ast::StmtAssign { targets, .. }) => {
+            Stmt::Assign(ast::StmtAssign { targets, value, .. }) => {
                 if let [Expr::Starred(ast::ExprStarred { range, .. })] = targets.as_slice() {
                     // test_ok single_starred_assignment_target
                     // (*a,) = (1,)
@@ -105,6 +105,19 @@ impl SemanticSyntaxChecker {
                         *range,
                     );
                 }
+
+                // test_ok assign_stmt_starred_expr_value
+                // _ = 4
+                // _ = [4]
+                // _ = (*[1],)
+                // _ = *[1],
+
+                // test_err assign_stmt_starred_expr_value
+                // _ = *[42]
+                // _ = *{42}
+                // _ = *list()
+                // _ = *(p + q)
+                Self::invalid_star_expression(value, ctx);
             }
             Stmt::Return(ast::StmtReturn { value, range }) => {
                 if let Some(value) = value {