Improve "ago" translation to Greek #1184

pothitos · 2024-08-23T19:15:18Z

Pull Request Checklist

🧪 Added tests for changed code.
🛠️ All tests pass when run locally (run tox or make test to find out!).
🧹 All linting checks pass when run locally (run tox -e lint or make lint to find out!).
📚 Updated documentation for changed code.
⏩ Code is up-to-date with the master branch.

Description of Changes

Hello and thanks for this library! While trying to migrate from humanize package to arrow, I executed

>>> arrow.get('2013-05-11T21:23:58.970460+07:00').humanize()
'11 years ago'
>>> arrow.get('2013-05-11T21:23:58.970460+07:00').humanize(locale='el')
'11 χρόνια πριν'

The later is printed by humanize as

'πριν από 11 χρόνια'

which is more natural/correct in Greek.

https://github.com/python-humanize/humanize/blob/4da8299fdcf9ad0c56be082b42ee7bee14ee4c4e/src/humanize/locale/el_GR/LC_MESSAGES/humanize.po#L344

Other than that, I fixed Greek abbreviated May accent, so as to be aligned with the full name 15 lines above.

jadchaar · 2024-08-24T00:44:22Z

Hi @pothitos would it be possible to add a unit test for this change?

codecov · 2024-08-25T19:21:24Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (87a1a77) to head (01769dd).
Report is 5 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff            @@
##            master     #1184   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           10        10           
  Lines         2326      2323    -3     
  Branches       400       357   -43     
=========================================
- Hits          2326      2323    -3

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

pothitos · 2024-08-25T19:26:22Z

Sure, Jad! Done!

jadchaar

LGTM!

Bumps [arrow](https://github.com/arrow-py/arrow) from 1.3.0 to 1.4.0. <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/arrow-py/arrow/blob/master/CHANGELOG.rst">arrow's changelog</a>.</em></p> <blockquote> <h2>1.4.0 (2025-10-18)</h2> <ul> <li>[ADDED] Added <code>week_start</code> parameter to <code>floor()</code> and <code>ceil()</code> methods. <code>PR [#1222](arrow-py/arrow#1222) <https://github.com/arrow-py/arrow/pull/1222></code>_</li> <li>[ADDED] Added <code>FORMAT_RFC3339_STRICT</code> with a T separator. <code>PR [#1201](arrow-py/arrow#1201) <https://github.com/arrow-py/arrow/pull/1201></code>_</li> <li>[ADDED] Added Macedonian in Latin locale support. <code>PR [#1200](arrow-py/arrow#1200) <https://github.com/arrow-py/arrow/pull/1200></code>_</li> <li>[ADDED] Added Persian/Farsi locale support. <code>PR [#1190](arrow-py/arrow#1190) <https://github.com/arrow-py/arrow/pull/1190></code>_</li> <li>[ADDED] Added week and weeks to Thai locale timeframes. <code>PR [#1218](arrow-py/arrow#1218) <https://github.com/arrow-py/arrow/pull/1218></code>_</li> <li>[ADDED] Added weeks to Catalan locale. <code>PR [#1189](arrow-py/arrow#1189) <https://github.com/arrow-py/arrow/pull/1189></code>_</li> <li>[ADDED] Added Persian names of months, month-abbreviations and day-abbreviations in Gregorian calendar. <code>PR [#1172](arrow-py/arrow#1172) <https://github.com/arrow-py/arrow/pull/1172></code>_</li> <li>[CHANGED] Migrated Arrow to use ZoneInfo for timezones instead of pytz. <code>PR [#1217](arrow-py/arrow#1217) <https://github.com/arrow-py/arrow/pull/1217></code>_</li> <li>[FIXED] Fixed humanize month limits. <code>PR [#1224](arrow-py/arrow#1224) <https://github.com/arrow-py/arrow/pull/1224></code>_</li> <li>[FIXED] Fixed type hint of <code>Arrow.__getattr__</code>. <code>PR [#1171](arrow-py/arrow#1171) <https://github.com/arrow-py/arrow/pull/1171></code>_</li> <li>[FIXED] Fixed spelling and removed poorly used expressions in Korean locale. <code>PR [#1181](arrow-py/arrow#1181) <https://github.com/arrow-py/arrow/pull/1181></code>_</li> <li>[FIXED] Updated <code>shift()</code> method for issue <a href="https://redirect.github.com/arrow-py/arrow/issues/1145">#1145</a>. <code>PR [#1194](arrow-py/arrow#1194) <https://github.com/arrow-py/arrow/pull/1194></code>_</li> <li>[FIXED] Improved Greek locale translations (seconds, days, "ago", and month typo). <code>PR [#1184](arrow-py/arrow#1184) <https://github.com/arrow-py/arrow/pull/1184></code><em>, <code>PR [#1186](arrow-py/arrow#1186) <https://github.com/arrow-py/arrow/pull/1186></code></em></li> <li>[FIXED] Addressed <code>datetime.utcnow</code> deprecation warning. <code>PR [#1182](arrow-py/arrow#1182) <https://github.com/arrow-py/arrow/pull/1182></code>_</li> <li>[INTERNAL] Added codecov test results. <code>PR [#1223](arrow-py/arrow#1223) <https://github.com/arrow-py/arrow/pull/1223></code>_</li> <li>[INTERNAL] Updated CI dependencies (actions/setup-python, actions/checkout, codecov/codecov-action, actions/cache).</li> <li>[INTERNAL] Added docstrings to parser.py. <code>PR [#1010](arrow-py/arrow#1010) <https://github.com/arrow-py/arrow/pull/1010></code>_</li> <li>[INTERNAL] Updated Python versions support and bumped CI dependencies. <code>PR [#1177](arrow-py/arrow#1177) <https://github.com/arrow-py/arrow/pull/1177></code>_</li> <li>[INTERNAL] Added dependabot for GitHub actions. <code>PR [#1193](arrow-py/arrow#1193) <https://github.com/arrow-py/arrow/pull/1193></code>_</li> <li>[INTERNAL] Moved dateutil types to test requirements. <code>PR [#1183](arrow-py/arrow#1183) <https://github.com/arrow-py/arrow/pull/1183></code>_</li> <li>[INTERNAL] Added documentation link for <code>arrow.format</code>. <code>PR [#1180](arrow-py/arrow#1180) <https://github.com/arrow-py/arrow/pull/1180></code>_</li> </ul> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/arrow-py/arrow/commit/2c1f5185ad66bf3b1cf8c0812f4b4fe65ac46656"><code>2c1f518</code></a> Bump release CI flow to use Python 3.14</li> <li><a href="https://github.com/arrow-py/arrow/commit/2483bfea4ec8a4da609036aba3ce1b32cb571875"><code>2483bfe</code></a> Bump changelog date</li> <li><a href="https://github.com/arrow-py/arrow/commit/c61de9299733da6d4a7e8badabae43684a3f9da2"><code>c61de92</code></a> Bump version and add changelog (<a href="https://redirect.github.com/arrow-py/arrow/issues/1228">#1228</a>)</li> <li><a href="https://github.com/arrow-py/arrow/commit/c3bb589536b283e3e3886d1d6bc01a6374c8e656"><code>c3bb589</code></a> Update pypy CI version and update pre-commit dependencies</li> <li><a href="https://github.com/arrow-py/arrow/commit/85cd905332d108303da1cbd0f2336fcae058147f"><code>85cd905</code></a> Run tests on next Python release (<a href="https://redirect.github.com/arrow-py/arrow/issues/1227">#1227</a>)</li> <li><a href="https://github.com/arrow-py/arrow/commit/4c8c44aefc0e5504b9c3cbf0d6adbb0ec4aa4571"><code>4c8c44a</code></a> Add week_start parameter to floor() and ceil() (<a href="https://redirect.github.com/arrow-py/arrow/issues/1222">#1222</a>)</li> <li><a href="https://github.com/arrow-py/arrow/commit/7ccbe66122ca53d90acf9c69c37aa95c81a1fe89"><code>7ccbe66</code></a> add codecov test results (<a href="https://redirect.github.com/arrow-py/arrow/issues/1223">#1223</a>)</li> <li><a href="https://github.com/arrow-py/arrow/commit/05cd9b47d0db1c22b44cb739832f1b9701855313"><code>05cd9b4</code></a> fix humanize month limits (<a href="https://redirect.github.com/arrow-py/arrow/issues/1224">#1224</a>)</li> <li><a href="https://github.com/arrow-py/arrow/commit/ea756ea779468b0c6a9f45439dc05cfd5e71ee1e"><code>ea756ea</code></a> Bump actions/setup-python from 5 to 6 (<a href="https://redirect.github.com/arrow-py/arrow/issues/1220">#1220</a>)</li> <li><a href="https://github.com/arrow-py/arrow/commit/86f7520f15b2dd46f9c49f71ce5c15bbc537ed67"><code>86f7520</code></a> Bump actions/checkout from 4 to 5 (<a href="https://redirect.github.com/arrow-py/arrow/issues/1219">#1219</a>)</li> <li>Additional commits viewable in <a href="https://github.com/arrow-py/arrow/compare/1.3.0...1.4.0">compare view</a></li> </ul> </details> <br /> [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=arrow&package-manager=uv&previous-version=1.3.0&new-version=1.4.0)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: onerandomusername <[email protected]>

Fix "ago" Greek translation and month typo

01769dd

jadchaar approved these changes Aug 26, 2024

View reviewed changes

jadchaar merged commit 02e3b1b into arrow-py:master Aug 26, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Improve "ago" translation to Greek #1184

Improve "ago" translation to Greek #1184

pothitos commented Aug 23, 2024 •

edited

Loading

Uh oh!

jadchaar commented Aug 24, 2024

Uh oh!

codecov bot commented Aug 25, 2024 •

edited

Loading

Uh oh!

pothitos commented Aug 25, 2024

Uh oh!

jadchaar left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Improve "ago" translation to Greek #1184

Improve "ago" translation to Greek #1184

Conversation

pothitos commented Aug 23, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pull Request Checklist

Description of Changes

Uh oh!

jadchaar commented Aug 24, 2024

Uh oh!

codecov bot commented Aug 25, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

pothitos commented Aug 25, 2024

Uh oh!

jadchaar left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

pothitos commented Aug 23, 2024 •

edited

Loading

codecov bot commented Aug 25, 2024 •

edited

Loading