Fix overflow on 32-bit Linux systems #931
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #931 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 10 10
Lines 1896 1896
Branches 311 311
=========================================
Hits 1896 1896
Continue to review full report at Codecov.
|
5 tasks
krisfremen
approved these changes
Feb 28, 2021
Member
krisfremen
left a comment
krisfremen
left a comment
There was a problem hiding this comment.
We were hoping to get away from all the hard coded dates, but they just pull us back in. 😆
LGTM.
Member
Author
|
Hopefully by 2038 these can be fully removed 😂. Another Y2K on the horizon in 2038? |
This was referenced Mar 8, 2021
This was referenced Mar 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
Thank you for taking the time to improve Arrow! Before submitting your pull request, please check all appropriate boxes:
toxormake testto find out!).tox -e lintormake lintto find out!).masterbranch.If you have any questions about your code changes or any of the points above, please submit your questions along with the pull request and we will try our best to help!
Description of Changes
Fixes OverflowError on 32-bit Linux systems.
Closes: #930