From ae51e852e3d4e44da64afd820f9add968102ebc7 Mon Sep 17 00:00:00 2001 From: Arnaud Zheng Date: Wed, 2 Sep 2026 08:57:58 +0200 Subject: [PATCH] feat(ui): rework the interface and front-end practices Correctness: - gate TanStackRouterDevtools behind import.meta.env.DEV and lazy-load it, it was shipping to production unconditionally - reportWebVitals() was called with no callback, so its own guard clause made it a no-op forever. Wired it to actually forward Core Web Vitals to Umami - moved the lore video iframe out of ModalDescription (a

, invalid HTML for an iframe, and it made the dialog's accessible description empty), gave it a real description, and dropped ?autoplay=1 (WCAG 1.4.2) - AnimatePresence wrapped a single stable-keyed container instead of the cart items themselves, so item exit animations never fired Accessibility: - --ring was too light to pass 3:1 non-text contrast in either theme, darkened both - the modal close button had a ~16px hit area, now 44px with a visible hover state - "Read Lore" was a button that called window.open(), now a real link - the mobile cart toggle gets aria-expanded/aria-controls, the cart is a landmark (