From 4a82a1ad803b16a8c38a82d039215b627f43277a Mon Sep 17 00:00:00 2001 From: mmagician Date: Thu, 29 Dec 2022 14:40:27 +0100 Subject: [PATCH 1/2] tagname should be prefixed with "v" --- makefile | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/makefile b/makefile index 833c8a830..fee982a5c 100644 --- a/makefile +++ b/makefile @@ -11,6 +11,6 @@ ifndef VERSION endif git pull cargo update - git tag $(VERSION) - git push origin $(VERSION) + git tag v$(VERSION) + git push origin v$(VERSION) cargo release publish --execute --verbose From 3d902bc7b7666591e0b0ba228246185e58e7f52b Mon Sep 17 00:00:00 2001 From: mmagician Date: Thu, 29 Dec 2022 14:40:44 +0100 Subject: [PATCH 2/2] suggest the full command complete with a version name --- .github/release-pr-template.ejs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/release-pr-template.ejs b/.github/release-pr-template.ejs index 749f193b5..515c86ed9 100644 --- a/.github/release-pr-template.ejs +++ b/.github/release-pr-template.ejs @@ -9,5 +9,5 @@ This is a release PR for version **<%= version.actual %>**<% You will still need to manually publish the cargo crate: ``` -$ make VERSION= release +$ make VERSION=<%= version.actual %> release ```