fix: nil pointer on logging (#4127)

zachaller · web-flow · commit a312e280214c · 2025-02-11T21:44:28.000-06:00
Signed-off-by: Zach Aller &lt;zachaller@users.noreply.github.com&gt;
diff --git a/rollout/ephemeralmetadata.go b/rollout/ephemeralmetadata.go
@@ -73,7 +73,7 @@ func (c *rolloutContext) syncEphemeralMetadata(ctx context.Context, rs *appsv1.R
 	// 1. Update ReplicaSet so that any new pods it creates will have the metadata
 	rs, err := c.updateReplicaSet(ctx, modifiedRS)
 	if err != nil {
-		c.log.Infof("failed to sync ephemeral metadata %v to ReplicaSet %s: %v", podMetadata, rs.Name, err)
+		c.log.Infof("failed to sync ephemeral metadata %v to ReplicaSet %s: %v", podMetadata, originalRSCopy.Name, err)
 		return fmt.Errorf("failed to sync ephemeral metadata: %w", err)
 	}
 	c.log.Infof("synced ephemeral metadata %v to ReplicaSet %s", podMetadata, rs.Name)

Original file line number	Diff line number	Diff line change
`@@ -73,7 +73,7 @@ func (c rolloutContext) syncEphemeralMetadata(ctx context.Context, rs appsv1.R`
`73`	`73`	`// 1. Update ReplicaSet so that any new pods it creates will have the metadata`
`74`	`74`	`rs, err := c.updateReplicaSet(ctx, modifiedRS)`
`75`	`75`	`if err != nil {`
`76`		`- c.log.Infof("failed to sync ephemeral metadata %v to ReplicaSet %s: %v", podMetadata, rs.Name, err)`
	`76`	`+ c.log.Infof("failed to sync ephemeral metadata %v to ReplicaSet %s: %v", podMetadata, originalRSCopy.Name, err)`
`77`	`77`	`return fmt.Errorf("failed to sync ephemeral metadata: %w", err)`
`78`	`78`	`}`
`79`	`79`	`c.log.Infof("synced ephemeral metadata %v to ReplicaSet %s", podMetadata, rs.Name)`