Skip to content

fix(ui): refactor tooltip, align action btns in app tile view #25098

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Nov 5, 2025
Merged

fix(ui): refactor tooltip, align action btns in app tile view #25098

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
2de20b7
fix(ui): refactor tooltip, align action btns
choejwoo Oct 28, 2025
c452383
fix build
choejwoo Oct 28, 2025
0f91cf3
rebuild
choejwoo Oct 28, 2025
b794038
CodeQL rebuild
choejwoo Oct 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions ui/src/app/applications/components/applications-list/applications-tiles.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,13 +53,19 @@
}

.applications-list__external-link {
align-items: center;
display: flex;

button {
background: none;
border: none;
cursor: pointer;
padding: 0;
margin: 0;
color: inherit;
display: flex;
align-items: center;
justify-content: center;

&:hover {
color: $argo-color-teal-5;
Expand Down
39 changes: 19 additions & 20 deletions ui/src/app/applications/components/applications-list/applications-tiles.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,26 +153,25 @@ export const ApplicationTiles = ({applications, syncApplication, refreshApplicat
title={getManagedByURL(app) ? `Managed by: ${getManagedByURL(app)}` : 'Open application'}>
<i className='fa fa-external-link-alt' />
</button>
<Tooltip content={favList?.includes(app.metadata.name) ? 'Remove Favorite' : 'Add Favorite'}>
<button
className='large-text-height'
onClick={e => {
e.stopPropagation();
favList?.includes(app.metadata.name)
? favList.splice(favList.indexOf(app.metadata.name), 1)
: favList.push(app.metadata.name);
services.viewPreferences.updatePreferences({appList: {...pref.appList, favoritesAppList: favList}});
}}>
<i
className={favList?.includes(app.metadata.name) ? 'fas fa-star fa-lg' : 'far fa-star fa-lg'}
style={{
cursor: 'pointer',
marginLeft: '7px',
color: favList?.includes(app.metadata.name) ? '#FFCE25' : '#8fa4b1'
}}
/>
</button>
</Tooltip>
<button
title={favList?.includes(app.metadata.name) ? 'Remove Favorite' : 'Add Favorite'}
className='large-text-height'
onClick={e => {
e.stopPropagation();
favList?.includes(app.metadata.name)
? favList.splice(favList.indexOf(app.metadata.name), 1)
: favList.push(app.metadata.name);
services.viewPreferences.updatePreferences({appList: {...pref.appList, favoritesAppList: favList}});
}}>
<i
className={favList?.includes(app.metadata.name) ? 'fas fa-star fa-lg' : 'far fa-star fa-lg'}
style={{
cursor: 'pointer',
margin: '-1px 0px 0px 7px',
color: favList?.includes(app.metadata.name) ? '#FFCE25' : '#8fa4b1'
}}
/>
</button>
</div>
</div>
</div>
Expand Down
Loading