feat(cli): add `argocd context` subcommands #25077

onasser1 · 2025-10-25T15:34:01Z

Related #19867

Signed-off-by: Omar Nasser <[email protected]>

bunnyshell · 2025-10-25T15:34:07Z

🔴 Preview Environment stopped on Bunnyshell

See: Environment Details | Pipeline Logs

Available commands (reply to this comment):

🔵 /bns:start to start the environment
🚀 /bns:deploy to redeploy the environment
❌ /bns:delete to remove the environment

onasser1 · 2025-10-25T15:35:11Z

/component cli

Signed-off-by: Omar Nasser <[email protected]>

cmd/argocd/commands/context.go

Signed-off-by: Omar Nasser <[email protected]>

nitishfy · 2025-10-27T09:06:34Z

cmd/argocd/commands/context.go


 # Switch Argo CD context
-argocd context cd.argoproj.io
+argocd context switch cd.argoproj.io


how about argocd context use?

If I'm not wrong, the switch command does exactly the same as use command, do you mean to change the name of the command from switch to be use?
If this is not what you mean, can you tell me the difference between them?

@onasser1 I believe @nitishfy is suggesting to use the term use instead of switch just like kubectl command

@ppapapetrou76 I added use as an alias for switch command in the latest commit.
Do you think I should replace switch completely with use? or keep them together with alias?

I think argocd context use cd.argoproj.io would be a more intuitive and consistent choice here.
The word “use” aligns with common CLI patterns like kubectl config use-context and clearly conveys the action of setting the active context.
You could still keep switch as an alias, but use would be better as the primary example.

cmd/argocd/commands/context.go

nitishfy · 2025-10-27T09:34:52Z

cmd/argocd/commands/context.go

-				err := deleteContext(args[0], clientOpts.ConfigPath)
-				errors.CheckError(err)
-				return
+func NewContextListCommand(clientOpts *argocdclient.ClientOptions) *cobra.Command {


Suggested change

func NewContextListCommand(clientOpts *argocdclient.ClientOptions) *cobra.Command {

// NewContextListCommand lists the contexts

func NewContextListCommand(clientOpts *argocdclient.ClientOptions) *cobra.Command {

Do you think we should to stick to the function comments format in app and login (i.e. https://github.com/argoproj/argo-cd/blob/master/cmd/argocd/commands/app.go#L124)
or apply your change and make the comment more meaningful (Anyway I see that the usage of that commands make it clear anyway) but I'd wait for your answer

nitishfy

Thank you for the PR. The code looks good to me. Here are few suggestions:

Please write comments in the code wherever required, eg. in the code for switch command.
Write unit tests for the utility functions.
You'll be required to run codegen to update the docs too.

nitishfy · 2025-10-27T09:39:39Z

util/localconfig/localconfig.go

 	return false
 }

+func (l *LocalConfig) GetContext(ctxName string) (*ContextRef, error) {


please write unit tests.

Co-authored-by: Nitish Kumar <[email protected]> Signed-off-by: Omar Nasser <[email protected]>

codecov · 2025-10-27T18:12:41Z

Codecov Report

❌ Patch coverage is 48.10127% with 41 lines in your changes missing coverage. Please review.
✅ Project coverage is 62.28%. Comparing base (b260143) to head (22ec297).
⚠️ Report is 70 commits behind head on master.

Files with missing lines	Patch %	Lines
cmd/argocd/commands/context.go	50.00%	34 Missing and 4 partials ⚠️
util/localconfig/localconfig.go	0.00%	3 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master   #25077      +/-   ##
==========================================
+ Coverage   60.83%   62.28%   +1.44%     
==========================================
  Files         350      351       +1     
  Lines       60430    49273   -11157     
==========================================
- Hits        36762    30688    -6074     
+ Misses      20754    15663    -5091     
- Partials     2914     2922       +8

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Omar Nasser <[email protected]>

Signed-off-by: Omar Nasser <[email protected]> Provide use command as alias for switch Signed-off-by: Omar Nasser <[email protected]>

Signed-off-by: Omar Nasser <[email protected]>

Mangaal · 2025-11-12T05:59:35Z

cmd/argocd/commands/context.go

+func NewContextSwitchCommand(clientOpts *argocdclient.ClientOptions) *cobra.Command {
+	command := &cobra.Command{
+		Use:     "switch",
+		Aliases: []string{"use"},
+		Short:   "Switch Argo CD Context",
+		Example: `   # Switch Argo CD Context
+	argocd context switch cd.argoproj.io`,


Suggested change

func NewContextSwitchCommand(clientOpts *argocdclient.ClientOptions) *cobra.Command {

command := &cobra.Command{

Use: "switch",

Aliases: []string{"use"},

Short: "Switch Argo CD Context",

Example: ` # Switch Argo CD Context

argocd context switch cd.argoproj.io`,

func NewContextUseCommand(clientOpts *argocdclient.ClientOptions) *cobra.Command {

command := &cobra.Command{

Use: "use",

Aliases: []string{"switch"},

Short: "Set Argo CD Context",

Example: ` # Set Argo CD context

argocd context use cd.argoproj.io`,

Mangaal

I have added a few comments and suggestions, feel free to resolve them if you agree with the changes.

onasser1 added 3 commits October 25, 2025 11:39

Update context command

e371c4a

Signed-off-by: Omar Nasser <[email protected]>

feat: Add login functionality to context command

30aaf10

Signed-off-by: Omar Nasser <[email protected]>

Changes from Codegen

a7c151a

Signed-off-by: Omar Nasser <[email protected]>

onasser1 requested review from a team as code owners October 25, 2025 15:34

refactor: remove code comments

6506a4a

Signed-off-by: Omar Nasser <[email protected]>

chansuke reviewed Oct 25, 2025

View reviewed changes

cmd/argocd/commands/context.go Outdated Show resolved Hide resolved

cmd/argocd/commands/context.go Outdated Show resolved Hide resolved

cmd/argocd/commands/context.go Outdated Show resolved Hide resolved

cmd/argocd/commands/context.go Outdated Show resolved Hide resolved

onasser1 added 2 commits October 25, 2025 22:13

refactor: apply review suggestions

56946f4

Signed-off-by: Omar Nasser <[email protected]>

refactor: apply review suggestions

ac142e9

Signed-off-by: Omar Nasser <[email protected]>

nitishfy reviewed Oct 27, 2025

View reviewed changes

cmd/argocd/commands/context.go Show resolved Hide resolved

nitishfy reviewed Oct 27, 2025

View reviewed changes

nitishfy requested changes Oct 27, 2025

View reviewed changes

nitishfy changed the title ~~feat: Add context login CLI sub command~~ feat(cli): add argocd context subcommands Oct 27, 2025

nitishfy reviewed Oct 27, 2025

View reviewed changes

nitishfy assigned onasser1 Oct 27, 2025

nitishfy mentioned this pull request Oct 27, 2025

feat: Improve context command #25075

Closed

Update cmd/argocd/commands/context.go

fcd1c27

Co-authored-by: Nitish Kumar <[email protected]> Signed-off-by: Omar Nasser <[email protected]>

add unit tests for localconfig

d28d54d

Signed-off-by: Omar Nasser <[email protected]>

onasser1 requested a review from nitishfy October 29, 2025 11:53

onasser1 force-pushed the feat/add-context-login-subcommand branch from 3580699 to 9c1e965 Compare October 29, 2025 14:00

onasser1 added 2 commits October 29, 2025 17:08

Changes from Codegen

9c1e965

Signed-off-by: Omar Nasser <[email protected]>

Provide use command as alias for switch

e3b7c18

Signed-off-by: Omar Nasser <[email protected]> Provide use command as alias for switch Signed-off-by: Omar Nasser <[email protected]>

onasser1 mentioned this pull request Nov 2, 2025

feat(cli): Add --all flag to logout command #25136

Open

refactor: remove useless GetContext function

22ec297

Signed-off-by: Omar Nasser <[email protected]>

nitishfy mentioned this pull request Nov 4, 2025

REQUEST: Promotion to Approver for @nitishfy argoproj/argoproj#405

Closed

6 tasks

Mangaal reviewed Nov 12, 2025

View reviewed changes

	func NewContextListCommand(clientOpts argocdclient.ClientOptions) cobra.Command {
	// NewContextListCommand lists the contexts
	func NewContextListCommand(clientOpts argocdclient.ClientOptions) cobra.Command {

feat(cli): add argocd context subcommands #25077

Are you sure you want to change the base?

feat(cli): add argocd context subcommands #25077

Conversation

onasser1 commented Oct 25, 2025

Uh oh!

bunnyshell bot commented Oct 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🔴 Preview Environment stopped on Bunnyshell

Uh oh!

onasser1 commented Oct 25, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

nitishfy Oct 27, 2025

Choose a reason for hiding this comment

Uh oh!

onasser1 Oct 27, 2025

Choose a reason for hiding this comment

Uh oh!

ppapapetrou76 Nov 4, 2025

Choose a reason for hiding this comment

Uh oh!

onasser1 Nov 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Mangaal Nov 12, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

nitishfy Oct 27, 2025

Choose a reason for hiding this comment

Uh oh!

onasser1 Oct 27, 2025

Choose a reason for hiding this comment

Uh oh!

nitishfy left a comment

Choose a reason for hiding this comment

Uh oh!

nitishfy Oct 27, 2025

Choose a reason for hiding this comment

Uh oh!

codecov bot commented Oct 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Mangaal Nov 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Mangaal left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

feat(cli): add `argocd context` subcommands #25077

feat(cli): add `argocd context` subcommands #25077

bunnyshell bot commented Oct 25, 2025 •

edited

Loading

onasser1 Nov 4, 2025 •

edited

Loading

codecov bot commented Oct 27, 2025 •

edited

Loading

Mangaal Nov 12, 2025 •

edited

Loading