fix(tests): race condition creating the sync id

[agaudreault]

Closes #23458

[bunnyshell]

❌ Preview Environment undeployed from Bunnyshell

Available commands (reply to this comment):

• 🚀 /bns:deploy to deploy the environment

[codecov]

Codecov Report

❌ Patch coverage is 60.00000% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 60.27%. Comparing base (a3ef471) to head (a9d982c).
⚠️ Report is 419 commits behind head on master.

Files with missing lines	Patch %	Lines
controller/syncid/id.go	57.14%	2 Missing and 1 partial ⚠️
controller/sync.go	66.66%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master   #23481      +/-   ##
==========================================
+ Coverage   60.15%   60.27%   +0.12%     
==========================================
  Files         343      344       +1     
  Lines       59004    59084      +80     
==========================================
+ Hits        35494    35615     +121     
+ Misses      20657    20604      -53     
- Partials     2853     2865      +12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.