Skip to content

Conversation

@svghadi
Copy link
Contributor

@svghadi svghadi commented May 30, 2025

It was observed that due to broken yarn.lock file, the Argo CD source-code fails to build on disconnected systems which uses npm cache to provide node packages. This PR fixes the yarn.lock file by simply running yarn install in the ui directory.

I am not sure how it was broken. My best guess would be, it was manually updated. However, according to yarn documentation, it should not be done.
Doc Ref:

Your yarn.lock file is auto-generated and should be handled entirely by Yarn. As you add/upgrade/remove dependencies with the Yarn CLI, it will automatically update your yarn.lock file. Do not edit this file directly as it is easy to break something.

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Toolchain Guide
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.
  • Optional. My organization is added to USERS.md.
  • Optional. For bug fixes, I've indicated what older releases this fix should be cherry-picked into (this may or may not happen depending on risk/complexity).

Signed-off-by: Siddhesh Ghadi <[email protected]>
@svghadi svghadi requested a review from a team as a code owner May 30, 2025 13:41
Copy link
Member

@ishitasequeira ishitasequeira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this @svghadi !!

@crenshaw-dev crenshaw-dev merged commit 2aceb1d into argoproj:release-2.14 May 30, 2025
19 checks passed
@svghadi svghadi deleted the 2.14-yarn-fix branch May 31, 2025 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants