fix: infinite reconciliation loop when app is in error #23047
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alexandre Gaudreault <[email protected]>
Signed-off-by: Alexandre Gaudreault <[email protected]>
Signed-off-by: Alexandre Gaudreault <[email protected]>
Signed-off-by: Alexandre Gaudreault <[email protected]>
Signed-off-by: Alexandre Gaudreault <[email protected]>
Signed-off-by: Alexandre Gaudreault <[email protected]>
…ive/argo-cd into fix-last-transition-update
crenshaw-dev
approved these changes
May 20, 2025
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## release-2.14 #23047 +/- ##
================================================
- Coverage 55.32% 55.31% -0.02%
================================================
Files 339 339
Lines 57355 57353 -2
================================================
- Hits 31733 31726 -7
- Misses 22927 22937 +10
+ Partials 2695 2690 -5 ☔ View full report in Codecov by Sentry. |
Closed
3 tasks
Member
Author
|
/cherry-pick release-3.0 |
|
Cherry-pick failed with |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When an app has error and is expired, it will constantly try to reconcile with level 2 because the
lastTransitionTimeis always updated.Related to #23018