Skip to content

docs: detailed valid states for pullRequestState#21873

Merged
todaywasawesome merged 3 commits into
argoproj:masterfrom
kthoms:link_pr_state
May 15, 2025
Merged

docs: detailed valid states for pullRequestState#21873
todaywasawesome merged 3 commits into
argoproj:masterfrom
kthoms:link_pr_state

Conversation

@kthoms
Copy link
Copy Markdown
Contributor

@kthoms kthoms commented Feb 13, 2025 •
edited
Loading

Without mentioning the states it takes a bit to look up the valid values from GitLab docs

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Toolchain Guide
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.
  • Optional. My organization is added to USERS.md.
  • Optional. For bug fixes, I've indicated what older releases this fix should be cherry-picked into (this may or may not happen depending on risk/complexity).

@kthoms
docs: detailed valid states for pullRequestState
85ad692 
Without mentioning the states it takes a bit to look up the valid values from GitLab docs

Signed-off-by: Karsten Thoms <karsten.thoms@gmail.com>
@kthoms kthoms requested review from a team as code owners February 13, 2025 18:55
@bunnyshell
Copy link
Copy Markdown

bunnyshell Bot commented Feb 13, 2025 •
edited
Loading

❗ Preview Environment undeploy from Bunnyshell failed

See: Environment Details | Pipeline Logs

Available commands (reply to this comment):

  • 🚀 /bns:deploy to redeploy the environment
  • ❌ /bns:delete to try again to remove the environment

nitishfy
nitishfy reviewed Feb 17, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@nitishfy nitishfy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you fix the failing checks?

todaywasawesome
todaywasawesome approved these changes Feb 20, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@todaywasawesome todaywasawesome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to go.

@nitishfy I don't think this failing test is related.

@codecov
Copy link
Copy Markdown

codecov Bot commented Feb 20, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 60.04%. Comparing base (a1431be) to head (55daa72).
⚠️ Report is 844 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master   #21873      +/-   ##
==========================================
+ Coverage   55.75%   60.04%   +4.29%     
==========================================
  Files         341      344       +3     
  Lines       57004    57781     +777     
==========================================
+ Hits        31780    34695    +2915     
+ Misses      22590    20330    -2260     
- Partials     2634     2756     +122

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@todaywasawesome todaywasawesome enabled auto-merge (squash) February 20, 2025 16:31
@andrii-korotkov-verkada andrii-korotkov-verkada added the ready-for-review An approver should give a final review and merge the PR label Feb 26, 2025
ishitasequeira
ishitasequeira reviewed Mar 2, 2025
View reviewed changes
Comment thread docs/operator-manual/applicationset/Generators-Pull-Request.md Outdated
* `tokenRef`: A `Secret` name and key containing the GitLab access token to use for requests. If not specified, will make anonymous requests which have a lower rate limit and can only see public repositories. (Optional)
* `labels`: Labels is used to filter the MRs that you want to target. (Optional)
* `pullRequestState`: PullRequestState is an additional MRs filter to get only those with a certain state. Default: "" (all states)
* `pullRequestState`: PullRequestState is an additional MRs filter to get only those with a certain state. By default all states. Valid values: `opened`, `closed`, `merged`, `locked` (Optional)
Copy link
Copy Markdown
Member

@ishitasequeira ishitasequeira Mar 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's add "" as a valid value as well.

agaudreault
agaudreault reviewed May 9, 2025
View reviewed changes
Comment thread docs/operator-manual/applicationset/Generators-Pull-Request.md Outdated
@agaudreault
Update docs/operator-manual/applicationset/Generators-Pull-Request.md
55daa72 
Signed-off-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com>
@todaywasawesome todaywasawesome merged commit 0e80034 into argoproj:master May 15, 2025
27 checks passed
ranakan19 pushed a commit to ranakan19/argo-cd that referenced this pull request May 20, 2025
@kthoms @todaywasawesome @ranakan19
docs: detailed valid states for pullRequestState (argoproj#21873)
5df4147 
Signed-off-by: Karsten Thoms <karsten.thoms@gmail.com>
Co-authored-by: Dan Garfield <dan@codefresh.io>
Signed-off-by: Kanika Rana <krana@redhat.com>
olivergondza pushed a commit to olivergondza/argo-cd that referenced this pull request May 20, 2025
@kthoms @todaywasawesome @olivergondza
docs: detailed valid states for pullRequestState (argoproj#21873)
d9177f4 
Signed-off-by: Karsten Thoms <karsten.thoms@gmail.com>
Co-authored-by: Dan Garfield <dan@codefresh.io>
Signed-off-by: Oliver Gondža <ogondza@gmail.com>
tylerrosnett pushed a commit to StateFarmIns/argo-cd that referenced this pull request May 27, 2025
@kthoms @todaywasawesome @tylerrosnett
docs: detailed valid states for pullRequestState (argoproj#21873)
1746f6d 
Signed-off-by: Karsten Thoms <karsten.thoms@gmail.com>
Co-authored-by: Dan Garfield <dan@codefresh.io>
chansuke pushed a commit to chansuke/argo-cd that referenced this pull request Jun 4, 2025
@kthoms @todaywasawesome @chansuke
docs: detailed valid states for pullRequestState (argoproj#21873)
837f4d3 
Signed-off-by: Karsten Thoms <karsten.thoms@gmail.com>
Co-authored-by: Dan Garfield <dan@codefresh.io>
dsuhinin pushed a commit to dsuhinin/argo-cd that referenced this pull request Jun 16, 2025
@kthoms @todaywasawesome @dsuhinin
docs: detailed valid states for pullRequestState (argoproj#21873)
89710ff 
Signed-off-by: Karsten Thoms <karsten.thoms@gmail.com>
Co-authored-by: Dan Garfield <dan@codefresh.io>
Signed-off-by: dsuhinin <suhinin.dmitriy@gmail.com>
dsuhinin pushed a commit to dsuhinin/argo-cd that referenced this pull request Jun 16, 2025
@kthoms @todaywasawesome @dsuhinin
docs: detailed valid states for pullRequestState (argoproj#21873)
2ab917f 
Signed-off-by: Karsten Thoms <karsten.thoms@gmail.com>
Co-authored-by: Dan Garfield <dan@codefresh.io>
Signed-off-by: dsuhinin <suhinin.dmitriy@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ishitasequeira ishitasequeira ishitasequeira left review comments

@nitishfy nitishfy nitishfy left review comments

@todaywasawesome todaywasawesome todaywasawesome approved these changes

@agaudreault agaudreault agaudreault approved these changes

+1 more reviewer

@andrii-korotkov-verkada andrii-korotkov-verkada andrii-korotkov-verkada approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

ready-for-review An approver should give a final review and merge the PR

Projects

Argo CD Review
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@kthoms @todaywasawesome @ishitasequeira @agaudreault @nitishfy @andrii-korotkov-verkada