Skip to content

Conversation

@adriananeci
Copy link
Contributor

Temporary disable TestMaxPodLogsRender to run when go test -race flag is enabled
Alternative to #21201.

It should be reverted once #21189 or similar is implemented.

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Toolchain Guide
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.
  • Optional. My organization is added to USERS.md.
  • Optional. For bug fixes, I've indicated what older releases this fix should be cherry-picked into (this may or may not happen depending on risk/complexity).

@adriananeci adriananeci requested a review from a team as a code owner December 16, 2024 15:56
@bunnyshell
Copy link

bunnyshell bot commented Dec 16, 2024

❌ Preview Environment deleted from Bunnyshell

Available commands (reply to this comment):

  • 🚀 /bns:deploy to deploy the environment

@codecov
Copy link

codecov bot commented Dec 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (master@c090f84). Learn more about missing BASE report.
Report is 447 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##             master   #21204   +/-   ##
=========================================
  Coverage          ?   55.23%           
=========================================
  Files             ?      324           
  Lines             ?    55663           
  Branches          ?        0           
=========================================
  Hits              ?    30748           
  Misses            ?    22288           
  Partials          ?     2627           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@adriananeci
Copy link
Contributor Author

Closing in favor of #21189

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant