Skip to content

Commit cdb69cf

Browse files
committed
fix 22606
Signed-off-by: sivchari <[email protected]>
1 parent 881448e commit cdb69cf

File tree

3 files changed

+34
-3
lines changed

3 files changed

+34
-3
lines changed

reposerver/repository/repository.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1096,7 +1096,7 @@ func helmTemplate(appPath string, repoRoot string, env *v1alpha1.Env, q *apiclie
10961096
templateOpts := &helm.TemplateOpts{
10971097
Name: appName,
10981098
Namespace: q.ApplicationSource.GetNamespaceOrDefault(q.Namespace),
1099-
KubeVersion: text.SemVer(q.ApplicationSource.GetKubeVersionOrDefault(q.KubeVersion)),
1099+
KubeVersion: q.ApplicationSource.GetKubeVersionOrDefault(q.KubeVersion),
11001100
APIVersions: q.ApplicationSource.GetAPIVersionsOrDefault(q.ApiVersions),
11011101
Set: map[string]string{},
11021102
SetString: map[string]string{},

util/helm/helm_test.go

Lines changed: 25 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -219,6 +219,29 @@ func TestAPIVersions(t *testing.T) {
219219
assert.Equal(t, "sample/v2", objs[0].GetAPIVersion())
220220
}
221221

222+
func TestIssue22606(t *testing.T) {
223+
h, err := NewHelmApp("./testdata/tests", nil, false, "", "", "", false)
224+
require.NoError(t, err)
225+
226+
objs, err := template(h, &TemplateOpts{KubeVersion: "1.30.11+IKS"})
227+
require.NoError(t, err)
228+
require.Len(t, objs, 2)
229+
230+
for _, obj := range objs {
231+
if obj.GetKind() != "ConfigMap" {
232+
continue
233+
}
234+
var configMap corev1.ConfigMap
235+
err := runtime.DefaultUnstructuredConverter.FromUnstructured(obj.Object, &configMap)
236+
require.NoError(t, err)
237+
if data, ok := configMap.Data["kubeVersion"]; ok {
238+
assert.Equal(t, "v1.30.11+IKS", data)
239+
return
240+
}
241+
t.Fatal("expected kubeVersion key not found in configMap")
242+
}
243+
}
244+
222245
func TestSkipCrds(t *testing.T) {
223246
h, err := NewHelmApp("./testdata/crds", nil, false, "", "", "", false)
224247
require.NoError(t, err)
@@ -242,11 +265,11 @@ func TestSkipTests(t *testing.T) {
242265

243266
objs, err := template(h, &TemplateOpts{SkipTests: false})
244267
require.NoError(t, err)
245-
require.Len(t, objs, 1)
268+
require.Len(t, objs, 2)
246269

247270
objs, err = template(h, &TemplateOpts{})
248271
require.NoError(t, err)
249-
require.Len(t, objs, 1)
272+
require.Len(t, objs, 2)
250273

251274
objs, err = template(h, &TemplateOpts{SkipTests: true})
252275
require.NoError(t, err)
Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,8 @@
1+
apiVersion: v1
2+
kind: ConfigMap
3+
metadata:
4+
name: test-map
5+
annotations:
6+
"helm.sh/hook": test
7+
data:
8+
kubeVersion: {{.Capabilities.KubeVersion}}

0 commit comments

Comments
 (0)