fix: application exist panic when execute api call (#8188)

pasha-codefresh · jannfis · commit b1e3a07d9281 · 2022-01-15T09:05:19.000+01:00
fix: application exist panic when execute api call (#8188) Signed-off-by: pashavictorovich <pavel@codefresh.io>
diff --git a/server/application/application.go b/server/application/application.go
@@ -213,7 +213,7 @@ func (s *Server) Create(ctx context.Context, q *application.ApplicationCreateReq
 		return existing, nil
 	}
 	if q.Upsert == nil || !*q.Upsert {
-		return nil, status.Errorf(codes.InvalidArgument, argo.GenerateSpecIsDifferentErrorMessage("application", existing.Spec, a.Spec))
+		return nil, status.Errorf(codes.InvalidArgument, "existing application spec is different, use upsert flag to force update")
 	}
 	if err := s.enf.EnforceErr(ctx.Value("claims"), rbacpolicy.ResourceApplications, rbacpolicy.ActionUpdate, appRBACName(a)); err != nil {
 		return nil, err

Original file line number	Diff line number	Diff line change
`@@ -213,7 +213,7 @@ func (s Server) Create(ctx context.Context, q application.ApplicationCreateReq`
`213`	`213`	`return existing, nil`
`214`	`214`	`}`
`215`	`215`	`if q.Upsert == nil \|\| !*q.Upsert {`
`216`		`- return nil, status.Errorf(codes.InvalidArgument, argo.GenerateSpecIsDifferentErrorMessage("application", existing.Spec, a.Spec))`
	`216`	`+ return nil, status.Errorf(codes.InvalidArgument, "existing application spec is different, use upsert flag to force update")`
`217`	`217`	`}`
`218`	`218`	`if err := s.enf.EnforceErr(ctx.Value("claims"), rbacpolicy.ResourceApplications, rbacpolicy.ActionUpdate, appRBACName(a)); err != nil {`
`219`	`219`	`return nil, err`