(chore) lint

Author: wrmedford

server/server_test.go

@@ -816,7 +816,7 @@ func TestAuthenticate_3rd_party_JWTs(t *testing.T) {
 			claims:                jwt.RegisteredClaims{Audience: jwt.ClaimStrings{common.ArgoCDClientAppID}, Subject: "admin", ExpiresAt: jwt.NewNumericDate(time.Now())},
 			expectedErrorContains: common.TokenVerificationError,
 			// Set to nil so we can do a separate check for issuer presence
-			expectedClaims:        nil,
+			expectedClaims: nil,
 		},
 		{
 			test:                  "anonymous enabled, expired token, admin claim",
@@ -872,7 +872,7 @@ func TestAuthenticate_3rd_party_JWTs(t *testing.T) {
 			useDex:                true,
 			expectedErrorContains: common.TokenVerificationError,
 			// Set to nil so we can do a separate check for issuer presence
-			expectedClaims:        nil,
+			expectedClaims: nil,
 		},
 		{
 			test:                  "external OIDC: anonymous enabled, expired token, admin claim",
@@ -915,21 +915,22 @@ func TestAuthenticate_3rd_party_JWTs(t *testing.T) {
 
 			ctx, err = argocd.Authenticate(ctx)
 			claims := ctx.Value("claims")
-			
+
 			// Special handling for expired token test cases
-			if strings.Contains(testDataCopy.test, "expired token") && claims != nil {
+			switch {
+			case strings.Contains(testDataCopy.test, "expired token") && claims != nil:
 				// For expired tokens, just verify that the claims contain an issuer field
 				// without checking its specific value
 				if mapClaims, ok := claims.(jwt.MapClaims); ok {
 					_, hasIssuer := mapClaims["iss"]
 					assert.True(t, hasIssuer, "Claims for expired token should include 'iss' field")
 				}
-			} else if testDataCopy.expectedClaims == nil {
+			case testDataCopy.expectedClaims == nil:
 				assert.Nil(t, claims)
-			} else {
+			default:
 				assert.Equal(t, testDataCopy.expectedClaims, claims)
 			}
-			
+
 			if testDataCopy.expectedErrorContains != "" {
 				assert.ErrorContains(t, err, testDataCopy.expectedErrorContains, "Authenticate should have thrown an error and blocked the request")
 			} else {