Skip to content

Conversation

@nmirasch
Copy link
Contributor

What type of PR is this?

/kind enhancement

What does this PR do / why we need it:
Adding support for the Operator to be able to use ArgoCD in Any Namespaces with The Notification Controller. Support upstream Argo CD in any namespace feature in operator https://argo-cd.readthedocs.io/en/stable/operator-manual/notifications/#namespace-based-configuration

Which issue(s) this PR fixes:

Fixes https://issues.redhat.com/browse/GITOPS-8026 & https://issues.redhat.com/browse/GITOPS-8025

@nmirasch nmirasch marked this pull request as draft October 22, 2025 09:41
@svghadi
Copy link
Collaborator

svghadi commented Oct 23, 2025

Can have the cleanup logic similar to #1209 for consistency?

@nmirasch nmirasch force-pushed the GITOPS-8025 branch 7 times, most recently from 27f57fb to 576aff9 Compare October 28, 2025 10:49
@nmirasch nmirasch marked this pull request as ready for review October 28, 2025 11:02
Copy link
Collaborator

@svghadi svghadi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @nmirasch for the PR. While testing, I ran into below error

Example:

apiVersion: argoproj.io/v1beta1
kind: ArgoCD
metadata:
  name: test
spec:
  sourceNamespaces:
    - apps
  notifications:
    enabled: true
    sourceNamespaces:
      - apps

Error

- lastTransitionTime: "2025-10-29T04:49:07Z"
    message: |-
      failed to create rolebinding test-default-notifications in namespace apps
      RoleBinding.rbac.authorization.k8s.io "test-default-notifications" is invalid: roleRef.apiGroup: Unsupported value: "meta.k8s.io": supported values: "rbac.authorization.k8s.io"
    reason: ErrorOccurred

@nmirasch nmirasch force-pushed the GITOPS-8025 branch 2 times, most recently from b2bbf43 to 90390a0 Compare October 29, 2025 13:43
@nmirasch
Copy link
Contributor Author

@svghadi code updated!

@svghadi
Copy link
Collaborator

svghadi commented Oct 30, 2025

I was wondering if we should consider creating a NotificationsConfiguration CR in the source namespaces as well, similar to what we do in the Argo CD instance namespace. This would provide a consistent UX where users manage the argocd-notifications-cm ConfigMap through the NotificationsConfiguration CR instead of editing the ConfigMap directly.

Copy link
Collaborator

@svghadi svghadi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good. Left few comments.

Copy link
Collaborator

@svghadi svghadi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks.

@svghadi
Copy link
Collaborator

svghadi commented Nov 5, 2025

Merging this one. Let's add e2e and docs in separate PR.

@svghadi svghadi merged commit e979a3f into argoproj-labs:master Nov 5, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants