-
Notifications
You must be signed in to change notification settings - Fork 1k
feat: Support notifications in any namespace #1912
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Can have the cleanup logic similar to #1209 for consistency? |
27f57fb to
576aff9
Compare
svghadi
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @nmirasch for the PR. While testing, I ran into below error
Example:
apiVersion: argoproj.io/v1beta1
kind: ArgoCD
metadata:
name: test
spec:
sourceNamespaces:
- apps
notifications:
enabled: true
sourceNamespaces:
- appsError
- lastTransitionTime: "2025-10-29T04:49:07Z"
message: |-
failed to create rolebinding test-default-notifications in namespace apps
RoleBinding.rbac.authorization.k8s.io "test-default-notifications" is invalid: roleRef.apiGroup: Unsupported value: "meta.k8s.io": supported values: "rbac.authorization.k8s.io"
reason: ErrorOccurredb2bbf43 to
90390a0
Compare
|
@svghadi code updated! |
|
I was wondering if we should consider creating a |
svghadi
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks good. Left few comments.
Signed-off-by: nmirasch <[email protected]>
…command Signed-off-by: nmirasch <[email protected]>
…espaces Signed-off-by: nmirasch <[email protected]>
…ead of propagating the configs Signed-off-by: nmirasch <[email protected]>
… spec Signed-off-by: nmirasch <[email protected]>
svghadi
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks.
|
Merging this one. Let's add e2e and docs in separate PR. |
What type of PR is this?
/kind enhancement
What does this PR do / why we need it:
Adding support for the Operator to be able to use ArgoCD in Any Namespaces with The Notification Controller. Support upstream Argo CD in any namespace feature in operator https://argo-cd.readthedocs.io/en/stable/operator-manual/notifications/#namespace-based-configuration
Which issue(s) this PR fixes:
Fixes https://issues.redhat.com/browse/GITOPS-8026 & https://issues.redhat.com/browse/GITOPS-8025