From 972f9a212223f921d830bc776f5d243ba8ad0929 Mon Sep 17 00:00:00 2001 From: Cheng Fang Date: Mon, 9 Sep 2024 16:22:21 -0400 Subject: [PATCH 1/2] fix: missing namespace on clusterrolebinding in install manifests Signed-off-by: Cheng Fang --- docs/install/installation.md | 8 ++++++++ .../rbac/argocd-image-updater-clusterrolebinding.yaml | 1 + manifests/install.yaml | 1 + 3 files changed, 10 insertions(+) diff --git a/docs/install/installation.md b/docs/install/installation.md index 813d1dbd..e0de89e4 100644 --- a/docs/install/installation.md +++ b/docs/install/installation.md @@ -28,6 +28,10 @@ Argo CD is running. Don't worry, without any configuration, it will not start me kubectl apply -n argocd -f https://raw.githubusercontent.com/argoproj-labs/argocd-image-updater/stable/manifests/install.yaml ``` +!!! warning +The installation manifests include `ClusterRoleBinding` resources that reference `argocd` namespace. If you are installing Argo CD into a different +namespace then make sure to update the namespace reference. + !!!note "A word on high availability" It is not advised to run multiple replicas of the same Argo CD Image Updater instance. Just leave the number of replicas at 1, otherwise weird side @@ -70,6 +74,10 @@ kubectl create namespace argocd-image-updater kubectl apply -n argocd-image-updater -f https://raw.githubusercontent.com/argoproj-labs/argocd-image-updater/stable/manifests/install.yaml ``` +!!! warning +The installation manifests include `ClusterRoleBinding` resources that reference `argocd` namespace. If you are installing Argo CD into a different +namespace then make sure to update the namespace reference. + !!!note "A word on high availability" It is not advised to run multiple replicas of the same Argo CD Image Updater instance. Just leave the number of replicas at 1, otherwise weird side diff --git a/manifests/base/rbac/argocd-image-updater-clusterrolebinding.yaml b/manifests/base/rbac/argocd-image-updater-clusterrolebinding.yaml index f7187102..9d8ec00a 100644 --- a/manifests/base/rbac/argocd-image-updater-clusterrolebinding.yaml +++ b/manifests/base/rbac/argocd-image-updater-clusterrolebinding.yaml @@ -13,3 +13,4 @@ roleRef: subjects: - kind: ServiceAccount name: argocd-image-updater + namespace: argocd diff --git a/manifests/install.yaml b/manifests/install.yaml index a3ed4796..165ac03f 100644 --- a/manifests/install.yaml +++ b/manifests/install.yaml @@ -82,6 +82,7 @@ roleRef: subjects: - kind: ServiceAccount name: argocd-image-updater + namespace: argocd --- apiVersion: v1 kind: ConfigMap From 812bfd37decff9049aff8b0bc031002a1785d913 Mon Sep 17 00:00:00 2001 From: Cheng Fang Date: Tue, 10 Sep 2024 16:10:32 -0400 Subject: [PATCH 2/2] Apply suggestions (indent the warning text) from code review Co-authored-by: Jann Fischer Signed-off-by: Cheng Fang --- docs/install/installation.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/docs/install/installation.md b/docs/install/installation.md index e0de89e4..36fe5c9e 100644 --- a/docs/install/installation.md +++ b/docs/install/installation.md @@ -29,7 +29,7 @@ kubectl apply -n argocd -f https://raw.githubusercontent.com/argoproj-labs/argoc ``` !!! warning -The installation manifests include `ClusterRoleBinding` resources that reference `argocd` namespace. If you are installing Argo CD into a different + The installation manifests include `ClusterRoleBinding` resources that reference `argocd` namespace. If you are installing Argo CD into a different namespace then make sure to update the namespace reference. !!!note "A word on high availability" @@ -75,7 +75,7 @@ kubectl apply -n argocd-image-updater -f https://raw.githubusercontent.com/argop ``` !!! warning -The installation manifests include `ClusterRoleBinding` resources that reference `argocd` namespace. If you are installing Argo CD into a different + The installation manifests include `ClusterRoleBinding` resources that reference `argocd` namespace. If you are installing Argo CD into a different namespace then make sure to update the namespace reference. !!!note "A word on high availability"