chore(tests): Add unit tests to image-updater pkg/health, pkg/version and pkg/registry #771
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mangaal <[email protected]>
Signed-off-by: Mangaal <[email protected]>
Signed-off-by: Mangaal <[email protected]>
Signed-off-by: Mangaal <[email protected]>
Signed-off-by: Mangaal <[email protected]>
Signed-off-by: Mangaal <[email protected]>
Signed-off-by: Mangaal <[email protected]>
Mangaal
requested review from
chengfang,
jannfis and
pasha-codefresh
as code owners
Signed-off-by: Mangaal <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #771 +/- ##
==========================================
+ Coverage 63.09% 67.98% +4.89%
==========================================
Files 31 31
Lines 3124 3124
==========================================
+ Hits 1971 2124 +153
+ Misses 1009 856 -153
Partials 144 144 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Mangaal <[email protected]>
Mangaal
changed the title
Mangaal
changed the title
chengfang
reviewed
Jul 10, 2024
Signed-off-by: Mangaal <[email protected]>
chengfang
approved these changes
Jul 11, 2024
sribiere-jellysmack
pushed a commit
to sribiere-jellysmack/argocd-image-updater
that referenced
this pull request
Aug 13, 2024
… and pkg/registry (argoproj-labs#771) Signed-off-by: Mangaal <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.