feat: Assume app type when write-back-type is set to kustomize #309
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Thanks, @iamnoah! I personally think that we should not have an override for that, but rather don't care about the application type when the WDYT? |
Contributor
Author
That makes sense to me, I'll adjust the logic when I can. |
iamnoah
force-pushed
the
source-type-override
branch
from
40ff7ca to
61035ec
Compare
iamnoah
force-pushed
the
source-type-override
branch
from
61035ec to
1098046
Compare
jannfis
changed the title
jannfis
approved these changes
Dec 16, 2021
sribiere-jellysmack
pushed a commit
to sribiere-jellysmack/argocd-image-updater
that referenced
this pull request
Aug 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recently started using tooling based on kustomize that is configured in Argo as a plugin. It stopped getting updates, so this is a workaround to continue to get kustomize updates.