fix: include reference string in invalid reference format error (#1303) #1304
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ellisvalentiner
requested review from
chengfang,
dkarpele,
ishitasequeira,
jannfis and
pasha-codefresh
as code owners
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1304 +/- ##
==========================================
- Coverage 70.35% 70.34% -0.02%
==========================================
Files 50 50
Lines 4460 4461 +1
==========================================
Hits 3138 3138
- Misses 1129 1130 +1
Partials 193 193 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…proj-labs#1303) When NewRepository fails to parse an image reference, log the actual reference string that failed validation. This makes it possible to identify which image reference is causing the "invalid reference format" error. Previously, users would see: Could not get tags from registry: invalid reference format Now users will see: Failed to create repository for image 'invalid@reference': invalid reference format This provides the necessary context to debug configuration issues with malformed image references. Fixes argoproj-labs#1303 Signed-off-by: Ellis Valentiner <[email protected]>
ellisvalentiner
force-pushed
the
master
branch
from
9137fcc to
fae480c
Compare
chengfang
approved these changes
Oct 28, 2025
Collaborator
|
Thanks for the fix. Can you also apply the same to master-annotation-based branch? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When NewRepository fails to parse an image reference, log the actual reference string that failed validation. This makes it possible to identify which image reference is causing the "invalid reference format" error.
Previously, users would see:
Could not get tags from registry: invalid reference format
Now users will see:
Failed to create repository for image 'invalid@reference': invalid reference format
This provides the necessary context to debug configuration issues with malformed image references.
Fixes #1303