Skip to content

chore(deps): Upgrade argo-cd version to 2.13.6 #1077

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

chore(deps): Upgrade argo-cd version to 2.13.6 #1077

wants to merge 2 commits into from

Conversation

@aali309
Copy link
Contributor

@aali309 aali309 commented Mar 27, 2025

This change Upgrade argo-cd version from 2.13.5 to 2.13.6

@codecov-commenter
Copy link

codecov-commenter commented Mar 27, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.49%. Comparing base (5aa0c7e) to head (1d4cbcf).
Report is 1 commits behind head on master.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #1077   +/-   ##
=======================================
  Coverage   63.49%   63.49%           
=======================================
  Files          15       15           
  Lines        2326     2326           
=======================================
  Hits         1477     1477           
  Misses        758      758           
  Partials       91       91

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

chengfang
chengfang reviewed Mar 28, 2025
View reviewed changes
go.mod Outdated
oras.land/oras-go/v2 v2.5.0 // indirect
sigs.k8s.io/json v0.0.0-20221116044647-bc3834ca7abd // indirect
sigs.k8s.io/structured-merge-diff/v4 v4.4.1 // indirect
sigs.k8s.io/structured-merge-diff/v4 v4.4.4-0.20241211184406-7bf59b3d70ee // indirect
Copy link
Collaborator

@chengfang chengfang Mar 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

any reason many seemingly unrelated modules are also upgraded, like golang.org/x/* ?

Copy link
Contributor Author

@aali309 aali309 Mar 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I explicitly updated github.com/argoproj/argo-cd/v2 from v2.13.5 to v2.13.6, the other package changes are
brought in by running go mod tidy and go mod vendor

@chengfang
Copy link
Collaborator

chengfang commented Mar 29, 2025

That's odd. I just tried the upgrade in my local, only argo-cd and go-redis are changed.

@aali309 aali309 closed this Mar 29, 2025
@aali309 aali309 force-pushed the updateArgoCDversionDeps branch from 9afef03 to b247265 Compare March 29, 2025 01:05
@aali309 aali309 reopened this Mar 29, 2025
dependabot bot and others added 2 commits March 28, 2025 21:18
@dependabot @aali309
chore(deps): bump github.com/golang-jwt/jwt/v4 from 4.5.1 to 4.5.2 (a…
ac3fd62 
…rgoproj-labs#1071)

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

trigger CI rerun

Signed-off-by: Atif Ali <[email protected]>

revert && redo update

Signed-off-by: Atif Ali <[email protected]>
@aali309
redo Upgrade argo-cd version to 2.13.6
1d4cbcf 
Signed-off-by: Atif Ali <[email protected]>
@aali309 aali309 force-pushed the updateArgoCDversionDeps branch from 9c3432f to 1d4cbcf Compare March 29, 2025 01:19
@aali309 aali309 closed this Mar 29, 2025
@aali309
Copy link
Contributor Author

aali309 commented Mar 29, 2025

Opened a cleaner PR

@aali309 aali309 deleted the updateArgoCDversionDeps branch March 29, 2025 01:38
@aali309
Copy link
Contributor Author

aali309 commented Mar 29, 2025

That's odd. I just tried the upgrade in my local, only argo-cd and go-redis are changed.

opened up a cleaner PR #1078

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chengfang chengfang chengfang left review comments

@jannfis jannfis Awaiting requested review from jannfis jannfis is a code owner

@pasha-codefresh pasha-codefresh Awaiting requested review from pasha-codefresh pasha-codefresh is a code owner

@ishitasequeira ishitasequeira Awaiting requested review from ishitasequeira ishitasequeira is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@aali309 @codecov-commenter @chengfang