Skip to content

Commit 99ca35a

Browse files
authored
feat: Support multiple platforms for test command (#396)
Signed-off-by: jannfis <[email protected]>
1 parent 8812ae1 commit 99ca35a

File tree

1 file changed

+6
-7
lines changed

1 file changed

+6
-7
lines changed

cmd/test.go

Lines changed: 6 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ func newTestCommand() *cobra.Command {
2929
ignoreTags []string
3030
disableKubeEvents bool
3131
rateLimit int
32-
platform string
32+
platforms []string
3333
)
3434
var runCmd = &cobra.Command{
3535
Use: "test IMAGE",
@@ -93,15 +93,14 @@ argocd-image-updater test nginx --allow-tags '^1.19.\d+(\-.*)*$' --update-strate
9393
logCtx.Infof("retrieving information about image")
9494

9595
vc.Options = options.NewManifestOptions()
96-
if platform != "" {
96+
for _, platform := range platforms {
9797
os, arch, variant, err := image.ParsePlatform(platform)
9898
if err != nil {
99-
logCtx.Fatalf("Platform %s: %v", platform, err)
99+
logCtx.Fatalf("Could not parse platform %s: %v", platform, err)
100100
}
101-
vc.Options = vc.Options.
102-
WithPlatform(os, arch, variant).
103-
WithMetadata(vc.Strategy.NeedsMetadata())
101+
vc.Options = vc.Options.WithPlatform(os, arch, variant)
104102
}
103+
vc.Options = vc.Options.WithMetadata(vc.Strategy.NeedsMetadata())
105104

106105
vc.Options.WithLogger(logCtx.AddField("application", "test"))
107106

@@ -180,7 +179,7 @@ argocd-image-updater test nginx --allow-tags '^1.19.\d+(\-.*)*$' --update-strate
180179
runCmd.Flags().BoolVar(&disableKubernetes, "disable-kubernetes", false, "whether to disable the Kubernetes client")
181180
runCmd.Flags().StringVar(&kubeConfig, "kubeconfig", "", "path to your Kubernetes client configuration")
182181
runCmd.Flags().StringVar(&credentials, "credentials", "", "the credentials definition for the test (overrides registry config)")
183-
runCmd.Flags().StringVar(&platform, "platform", fmt.Sprintf("%s/%s", runtime.GOOS, runtime.GOARCH), "limit images to given platform")
182+
runCmd.Flags().StringSliceVar(&platforms, "platforms", []string{fmt.Sprintf("%s/%s", runtime.GOOS, runtime.GOARCH)}, "limit images to given platforms")
184183
runCmd.Flags().BoolVar(&disableKubeEvents, "disable-kubernetes-events", false, "Disable kubernetes events")
185184
runCmd.Flags().IntVar(&rateLimit, "rate-limit", 20, "specificy registry rate limit (overrides registry.conf)")
186185
return runCmd

0 commit comments

Comments
 (0)