Skip to content

Commit a2c611d

Browse files
committed
fix merge conflicts
Signed-off-by: Rizwana777 <[email protected]>
1 parent 8874ad2 commit a2c611d

File tree

4 files changed

+289
-2
lines changed

4 files changed

+289
-2
lines changed

controllers/resources.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -418,7 +418,7 @@ func (r *RolloutManagerReconciler) reconcileRolloutsMetricsService(ctx context.C
418418
}
419419
if err := fetchObject(ctx, r.Client, cr.Namespace, actualSvc.Name, existingServiceMonitor); err != nil {
420420
if apierrors.IsNotFound(err) {
421-
err = r.createServiceMonitorIfAbsent(ctx, cr.Namespace, cr, actualSvc.Name, actualSvc.Name)
421+
err = r.createServiceMonitorIfAbsent(ctx, cr.Namespace, &cr, actualSvc.Name, actualSvc.Name)
422422
if err != nil {
423423
return err
424424
}

controllers/utils_test.go

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,10 +4,12 @@ import (
44
"context"
55

66
rolloutsmanagerv1alpha1 "github.com/argoproj-labs/argo-rollouts-manager/api/v1alpha1"
7+
monitoringv1 "github.com/prometheus-operator/prometheus-operator/pkg/apis/monitoring/v1"
78

89
. "github.com/onsi/ginkgo/v2"
910
. "github.com/onsi/gomega"
1011
corev1 "k8s.io/api/core/v1"
12+
crdv1 "k8s.io/apiextensions-apiserver/pkg/apis/apiextensions/v1"
1113
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
1214
"k8s.io/apimachinery/pkg/types"
1315
"k8s.io/client-go/kubernetes/scheme"
@@ -384,6 +386,12 @@ func makeTestReconciler(obj ...client.Object) *RolloutManagerReconciler {
384386
err := rolloutsmanagerv1alpha1.AddToScheme(s)
385387
Expect(err).ToNot(HaveOccurred())
386388

389+
err = monitoringv1.AddToScheme(s)
390+
Expect(err).ToNot(HaveOccurred())
391+
392+
err = crdv1.AddToScheme(s)
393+
Expect(err).ToNot(HaveOccurred())
394+
387395
cl := fake.NewClientBuilder().WithScheme(s).WithStatusSubresource(obj...).WithObjects(obj...).Build()
388396

389397
return &RolloutManagerReconciler{

go.mod

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,9 +6,11 @@ require (
66
github.com/go-logr/logr v1.2.4
77
github.com/onsi/ginkgo/v2 v2.11.0
88
github.com/onsi/gomega v1.27.10
9+
github.com/prometheus-operator/prometheus-operator/pkg/apis/monitoring v0.50.0
910
go.uber.org/zap v1.25.0
1011
gopkg.in/yaml.v2 v2.4.0
1112
k8s.io/api v0.28.3
13+
k8s.io/apiextensions-apiserver v0.28.3
1214
k8s.io/apimachinery v0.28.3
1315
k8s.io/client-go v0.28.3
1416
sigs.k8s.io/controller-runtime v0.16.3
@@ -65,7 +67,6 @@ require (
6567
google.golang.org/protobuf v1.33.0 // indirect
6668
gopkg.in/inf.v0 v0.9.1 // indirect
6769
gopkg.in/yaml.v3 v3.0.1 // indirect
68-
k8s.io/apiextensions-apiserver v0.28.3 // indirect
6970
k8s.io/component-base v0.28.3 // indirect
7071
k8s.io/klog/v2 v2.100.1 // indirect
7172
k8s.io/kube-openapi v0.0.0-20230717233707-2695361300d9 // indirect

0 commit comments

Comments
 (0)