添加udf插件加载日志 (#3)

Add print (#4)

* 添加更多的日志打印

Add print (#5)

* 修复插件加载的bug

删除测试用的日志输出 (#6)

调试bug (#7)

Add print for (#8)

* 调试bug

Add print for (#9)

* 调试bug

Add print for (#10)

* 调试bug

删除测试用的print打印

Author: EricJoy2048

ballista/rust/core/src/serde/physical_plan/from_proto.rs

@@ -591,7 +591,6 @@ impl TryFrom<&protobuf::PhysicalExprNode> for Arc<dyn PhysicalExpr> {
                                 &e.fun_name.to_owned()
                             ))
                         })?;
-
                     let scalar_udf = &*fun.clone();
                     let args = e
                         .expr

datafusion/src/plugin/plugin_manager.rs

@@ -62,11 +62,11 @@ impl GlobalPluginManager {
         }
         // find library file from udaf_plugin_path
         info!("load plugin from dir:{}", plugin_path);
-        println!("load plugin from dir:{}", plugin_path);
 
         let plugin_files = self.get_all_plugin_files(plugin_path)?;
 
         for plugin_file in plugin_files {
+            println!("load library :{}", plugin_file.path().to_str().unwrap());
             let library = Library::new(plugin_file.path()).map_err(|e| {
                 DataFusionError::IoError(io::Error::new(
                     io::ErrorKind::Other,
@@ -82,17 +82,18 @@ impl GlobalPluginManager {
                     "not found plugin_declaration in the library: {}",
                     plugin_file.path().to_str().unwrap()
                 );
-                return Ok(());
+                continue;
             }
 
             let dec = dec.unwrap().read();
 
             // ersion checks to prevent accidental ABI incompatibilities
 
             if dec.rustc_version != RUSTC_VERSION || dec.core_version != CORE_VERSION {
+                println!("Version mismatch rustc_version:{}, core_version:{}", RUSTC_VERSION, CORE_VERSION);
                 return Err(DataFusionError::IoError(io::Error::new(
                     io::ErrorKind::Other,
-                    "Version mismatch",
+                    format!("Version mismatch rustc_version:{}, core_version:{}", RUSTC_VERSION, CORE_VERSION),
                 )));
             }
 
@@ -138,10 +139,6 @@ impl GlobalPluginManager {
                             "load plugin from library file:{}",
                             item.path().to_str().unwrap()
                         );
-                        println!(
-                            "load plugin from library file:{}",
-                            item.path().to_str().unwrap()
-                        );
                         return Some(item);
                     }
                 }

datafusion/src/plugin/udf.rs

@@ -63,14 +63,15 @@ impl PluginRegistrar for UDFPluginManager {
                     format!("not found fn registrar_udf_plugin in the library: {}", e),
                 ))
             })?;
-
         let udf_plugin: Box<dyn UDFPlugin> = register_fun();
         udf_plugin
             .udf_names()
             .unwrap()
             .iter()
             .try_for_each(|udf_name| {
+                println!("udf_name: {}", udf_name);
                 if self.scalar_udfs.contains_key(udf_name) {
+                    println!("udf_name exists");
                     Err(DataFusionError::IoError(io::Error::new(
                         io::ErrorKind::Other,
                         format!("udf name: {} already exists", udf_name),
@@ -88,7 +89,9 @@ impl PluginRegistrar for UDFPluginManager {
             .unwrap()
             .iter()
             .try_for_each(|udaf_name| {
+                println!("udaf_name: {}", udaf_name);
                 if self.aggregate_udfs.contains_key(udaf_name) {
+                    println!("udaf_name exists");
                     Err(DataFusionError::IoError(io::Error::new(
                         io::ErrorKind::Other,
                         format!("udaf name: {} already exists", udaf_name),
@@ -101,6 +104,7 @@ impl PluginRegistrar for UDFPluginManager {
                     Ok(())
                 }
             })?;
+        self.libraries.push(library);
         Ok(())
     }