Fix alt text stripping accents and single quotes

Tofandel · Tofandel · commit 7bb0e9816ab0 · 2024-03-31T11:42:37.000+02:00
The altTextFrom method doesn't work well for non english characters and accents, it also uppercases every word which is weird
diff --git a/src/Models/Media.php b/src/Models/Media.php
@@ -49,10 +49,10 @@ public function altTextFrom($filename)
     {
         $filename = pathinfo($filename, PATHINFO_FILENAME);
         if (Str::endsWith($filename, '@2x')) {
-            $filename = substr($filename, 0, -2);
+            $filename = substr($filename, 0, -3);
         }
 
-        return ucwords(preg_replace('/[^a-zA-Z0-9]/', ' ', sanitizeFilename($filename)));
+        return Str::ucfirst(preg_replace('/-_/', ' ', sanitizeFilename($filename)));
     }
 
     public function canDeleteSafely()

Original file line number	Diff line number	Diff line change
`@@ -49,10 +49,10 @@ public function altTextFrom($filename)`
`49`	`49`	`{`
`50`	`50`	`$filename = pathinfo($filename, PATHINFO_FILENAME);`
`51`	`51`	`if (Str::endsWith($filename, '@2x')) {`
`52`		`- $filename = substr($filename, 0, -2);`
	`52`	`+ $filename = substr($filename, 0, -3);`
`53`	`53`	`}`
`54`	`54`
`55`		`- return ucwords(preg_replace('/[^a-zA-Z0-9]/', ' ', sanitizeFilename($filename)));`
	`55`	`+ return Str::ucfirst(preg_replace('/-_/', ' ', sanitizeFilename($filename)));`
`56`	`56`	`}`
`57`	`57`
`58`	`58`	`public function canDeleteSafely()`