Adding schema validation (#83)

* Waiting for backup restore

* Schema validation

* Bumping version number

* Added await

Author: apetenchea

arangoasync/collection.py

@@ -570,6 +570,7 @@ async def configure(
 
         Raises:
             CollectionConfigureError: If configuration fails.
+            ValueError: If parameters are invalid.
 
         References:
             - `change-the-properties-of-a-collection <https://docs.arango.ai/arangodb/stable/develop/http-api/collections/#change-the-properties-of-a-collection>`__
@@ -582,6 +583,8 @@ async def configure(
         if replication_factor is not None:
             data["replicationFactor"] = replication_factor
         if schema is not None:
+            if not isinstance(schema, dict) or len(schema) == 0:
+                raise ValueError("schema parameter must be a non-empty dict")
             data["schema"] = schema
         if wait_for_sync is not None:
             data["waitForSync"] = wait_for_sync

arangoasync/database.py

@@ -694,6 +694,8 @@ async def create_collection(
             key_options.validate()
             data["keyOptions"] = key_options.to_dict()
         if schema is not None:
+            if not isinstance(schema, dict) or len(schema) == 0:
+                raise ValueError("schema parameter must be a non-empty dict")
             data["schema"] = schema
         if shard_keys is not None:
             data["shardKeys"] = shard_keys

arangoasync/version.py

@@ -1 +1 @@
-__version__ = "1.1.0"
+__version__ = "1.2.0"

tests/test_backup.py

@@ -1,3 +1,5 @@
+import asyncio
+
 import pytest
 from packaging import version
 
@@ -36,6 +38,10 @@ async def test_backup(
         assert "list" in result
         result = await backup.restore(backup_id)
         assert "previous" in result
+
+        # Wait for restore to complete
+        await asyncio.sleep(10)
+
         config = {"local": {"type": "local"}}
         result = await backup.upload(backup_id, repository=backup_path, config=config)
         assert "uploadId" in result

tests/test_collection.py

@@ -50,6 +50,8 @@ async def test_collection_misc_methods(doc_col, bad_col, docs, cluster):
     assert new_properties.wait_for_sync == wfs
     with pytest.raises(CollectionConfigureError):
         await bad_col.configure(wait_for_sync=wfs)
+    with pytest.raises(ValueError):
+        await doc_col.configure(schema={})
 
     # Statistics
     statistics = await doc_col.statistics()

tests/test_database.py

@@ -352,6 +352,8 @@ async def test_create_drop_collection(db, bad_db, cluster):
         await db.create_collection(generate_col_name(), col_type=db)
     with pytest.raises(ValueError):
         await db.create_collection(generate_col_name(), key_options={})
+    with pytest.raises(ValueError):
+        await db.create_collection(generate_col_name(), schema={})
 
     # Drop the newly created collection
     assert await db.delete_collection(col_name) is True