Skip to content

Commit aefe2df

Browse files
committed
Format OAuth2 provider name better
The provider name is not that nice because it is just the provider key with the first letter capitalized. So, instead of showing that name, override the name with a nicer or more correct value as needed.
1 parent 8fdaaf2 commit aefe2df

File tree

11 files changed

+25
-29
lines changed

11 files changed

+25
-29
lines changed

src/lib/stores/oauth-providers.ts

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,7 @@ import Oidc from '../../routes/console/project-[project]/auth/oidcOAuth.svelte';
1111
import Okta from '../../routes/console/project-[project]/auth/oktaOAuth.svelte';
1212

1313
export type Provider = Models.Provider & {
14+
key: string;
1415
icon: string;
1516
docs?: string;
1617
component?: typeof SvelteComponent;
@@ -23,6 +24,8 @@ export type Providers = {
2324
const setProviders = (project: Models.Project): Provider[] => {
2425
return (
2526
project?.providers.map((n) => {
27+
let key = n.name.toLocaleLowerCase();
28+
let name = n.name;
2629
let docs: Provider['docs'];
2730
let icon: Provider['icon'] = n.name.toLowerCase();
2831
let component: Provider['component'] = Main;
@@ -74,16 +77,19 @@ const setProviders = (project: Models.Project): Provider[] => {
7477
docs = 'https://developers.facebook.com/';
7578
break;
7679
case 'github':
80+
name = 'GitHub';
7781
docs = 'https://developer.github.com';
7882
break;
7983
case 'gitlab':
84+
name = 'GitLab';
8085
docs = 'https://docs.gitlab.com/ee/api/';
8186
component = GitLab;
8287
break;
8388
case 'google':
8489
docs = 'https://support.google.com/googleapi/answer/6158849';
8590
break;
8691
case 'linkedin':
92+
name = 'LinkedIn';
8793
docs = 'https://developer.linkedin.com/';
8894
break;
8995
case 'microsoft':
@@ -94,6 +100,7 @@ const setProviders = (project: Models.Project): Provider[] => {
94100
docs = 'https://developers.notion.com/docs';
95101
break;
96102
case 'oidc':
103+
name = 'OpenID Connect';
97104
docs = 'https://openid.net/connect/faq/';
98105
component = Oidc;
99106
break;
@@ -102,9 +109,11 @@ const setProviders = (project: Models.Project): Provider[] => {
102109
component = Okta;
103110
break;
104111
case 'paypal':
112+
name = 'PayPal';
105113
docs = 'https://developer.paypal.com/docs/api/overview/';
106114
break;
107115
case 'paypalsandbox':
116+
name = 'PayPal Sandbox';
108117
icon = 'paypal';
109118
docs = 'https://developer.paypal.com/docs/api/overview/';
110119
break;
@@ -128,6 +137,7 @@ const setProviders = (project: Models.Project): Provider[] => {
128137
docs = 'https://developers.tradeshift.com/docs/api';
129138
break;
130139
case 'tradeshiftbox':
140+
name = 'Tradeshift Sandbox';
131141
icon = 'tradeshift';
132142
docs = 'https://developers.tradeshift.com/docs/api';
133143
break;
@@ -155,6 +165,8 @@ const setProviders = (project: Models.Project): Provider[] => {
155165

156166
return {
157167
...n,
168+
key,
169+
name,
158170
icon,
159171
docs,
160172
component

src/routes/console/project-[project]/auth/appleOAuth.svelte

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -63,9 +63,7 @@
6363
<div>
6464
<p>URI</p>
6565
<CopyInput
66-
value={`${
67-
sdk.forConsole.client.config.endpoint
68-
}/account/sessions/oauth2/callback/${provider.name.toLocaleLowerCase()}/${projectId}`} />
66+
value={`${sdk.forConsole.client.config.endpoint}/account/sessions/oauth2/callback/${provider.key}/${projectId}`} />
6967
</div>
7068
</FormList>
7169
<svelte:fragment slot="footer">

src/routes/console/project-[project]/auth/auth0OAuth.svelte

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -72,9 +72,7 @@
7272
<div>
7373
<p>URI</p>
7474
<CopyInput
75-
value={`${
76-
sdk.forConsole.client.config.endpoint
77-
}/account/sessions/oauth2/callback/${provider.name.toLocaleLowerCase()}/${projectId}`} />
75+
value={`${sdk.forConsole.client.config.endpoint}/account/sessions/oauth2/callback/${provider.key}/${projectId}`} />
7876
</div>
7977
</FormList>
8078
<svelte:fragment slot="footer">

src/routes/console/project-[project]/auth/authentikOAuth.svelte

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -72,9 +72,7 @@
7272
<div>
7373
<p>URI</p>
7474
<CopyInput
75-
value={`${
76-
sdk.forConsole.client.config.endpoint
77-
}/account/sessions/oauth2/callback/${provider.name.toLocaleLowerCase()}/${projectId}`} />
75+
value={`${sdk.forConsole.client.config.endpoint}/account/sessions/oauth2/callback/${provider.key}/${projectId}`} />
7876
</div>
7977
</FormList>
8078
<svelte:fragment slot="footer">

src/routes/console/project-[project]/auth/gitlabOAuth.svelte

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -70,9 +70,7 @@
7070
<div>
7171
<p>URI</p>
7272
<CopyInput
73-
value={`${
74-
sdk.forConsole.client.config.endpoint
75-
}/account/sessions/oauth2/callback/${provider.name.toLocaleLowerCase()}/${projectId}`} />
73+
value={`${sdk.forConsole.client.config.endpoint}/account/sessions/oauth2/callback/${provider.key}/${projectId}`} />
7674
</div>
7775
</FormList>
7876
<svelte:fragment slot="footer">

src/routes/console/project-[project]/auth/mainOAuth.svelte

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -63,9 +63,7 @@
6363
<div>
6464
<p>URI</p>
6565
<CopyInput
66-
value={`${
67-
sdk.forConsole.client.config.endpoint
68-
}/account/sessions/oauth2/callback/${provider.name.toLocaleLowerCase()}/${projectId}`} />
66+
value={`${sdk.forConsole.client.config.endpoint}/account/sessions/oauth2/callback/${provider.key}/${projectId}`} />
6967
</div>
7068
</FormList>
7169
<svelte:fragment slot="footer">

src/routes/console/project-[project]/auth/microsoftOAuth.svelte

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -72,9 +72,7 @@
7272
<div>
7373
<p>URI</p>
7474
<CopyInput
75-
value={`${
76-
sdk.forConsole.client.config.endpoint
77-
}/account/sessions/oauth2/callback/${provider.name.toLocaleLowerCase()}/${projectId}`} />
75+
value={`${sdk.forConsole.client.config.endpoint}/account/sessions/oauth2/callback/${provider.key}/${projectId}`} />
7876
</div>
7977
</FormList>
8078
<svelte:fragment slot="footer">

src/routes/console/project-[project]/auth/oidcOAuth.svelte

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -61,11 +61,11 @@
6161
</script>
6262

6363
<Modal {error} onSubmit={update} size="big" show on:close>
64-
<svelte:fragment slot="header">{provider.name.toUpperCase()} OAuth2 Settings</svelte:fragment>
64+
<svelte:fragment slot="header">{provider.name} OAuth2 Settings</svelte:fragment>
6565
<FormList>
6666
<p>
67-
To use {provider.name.toUpperCase()} authentication in your application, first fill in this
68-
form. For more info you can
67+
To use {provider.name} authentication in your application, first fill in this form. For more
68+
info you can
6969
<a class="link" href={provider.docs} target="_blank" rel="noopener noreferrer"
7070
>visit the docs.</a>
7171
</p>
@@ -110,9 +110,7 @@
110110
<div>
111111
<p>URI</p>
112112
<CopyInput
113-
value={`${
114-
sdk.forConsole.client.config.endpoint
115-
}/account/sessions/oauth2/callback/${provider.name.toLocaleLowerCase()}/${projectId}`} />
113+
value={`${sdk.forConsole.client.config.endpoint}/account/sessions/oauth2/callback/${provider.key}/${projectId}`} />
116114
</div>
117115
</FormList>
118116
<svelte:fragment slot="footer">

src/routes/console/project-[project]/auth/oktaOAuth.svelte

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -82,9 +82,7 @@
8282
<div>
8383
<p>URI</p>
8484
<CopyInput
85-
value={`${
86-
sdk.forConsole.client.config.endpoint
87-
}/account/sessions/oauth2/callback/${provider.name.toLocaleLowerCase()}/${projectId}`} />
85+
value={`${sdk.forConsole.client.config.endpoint}/account/sessions/oauth2/callback/${provider.key}/${projectId}`} />
8886
</div>
8987
</FormList>
9088
<svelte:fragment slot="footer">

src/routes/console/project-[project]/auth/settings/+page.svelte

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -75,7 +75,7 @@
7575
on:click={() => {
7676
selectedProvider = provider;
7777
trackEvent(`click_select_provider`, {
78-
provider: provider.name.toLowerCase()
78+
provider: provider.key
7979
});
8080
}}>
8181
<div class="image-item">

0 commit comments

Comments
 (0)