Refactor: Replace RUN_BEHAVIOR_VALUES with JS_OBJECT_RUN_BEHAVIOR_VALUES in utils and tests

- Introduced JS_OBJECT_RUN_BEHAVIOR_VALUES to include the new ON_PAGE_UNLOAD action run behavior.
- Updated references in the JSEditor utility functions and tests to use the new constant for consistency and improved functionality.
- Ensured all related tests reflect the changes to maintain expected behavior under various feature flag states.

Author: rahulbarwal

app/client/src/constants/AppsmithActionConstants/formConfig/PluginSettings.ts

@@ -21,6 +21,10 @@ export const RUN_BEHAVIOR_VALUES = [
     value: ActionRunBehaviour.MANUAL,
     children: "Manual",
   },
+];
+
+export const JS_OBJECT_RUN_BEHAVIOR_VALUES = [
+  ...RUN_BEHAVIOR_VALUES,
   {
     label: "On page unload",
     subText: "Query runs when the page unloads or when manually triggered",

app/client/src/pages/Editor/JSEditor/JSEditorToolbar/components/utils.test.ts

@@ -6,7 +6,7 @@ import {
   getDefaultRunBehaviorOptionWhenFeatureFlagIsDisabled,
   getRunBehaviorOptionsBasedOnFeatureFlags,
 } from "./utils";
-import { RUN_BEHAVIOR_VALUES } from "constants/AppsmithActionConstants/formConfig/PluginSettings";
+import { JS_OBJECT_RUN_BEHAVIOR_VALUES } from "constants/AppsmithActionConstants/formConfig/PluginSettings";
 import type { SelectOptionProps } from "@appsmith/ads";
 
 describe("getRunBehaviorOptions", () => {
@@ -19,26 +19,26 @@ describe("getRunBehaviorOptions", () => {
       {
         isReactiveActionsEnabled: true,
         isOnPageUnloadEnabled: true,
-        expectedOptions: RUN_BEHAVIOR_VALUES,
+        expectedOptions: JS_OBJECT_RUN_BEHAVIOR_VALUES,
       },
       {
         isReactiveActionsEnabled: false,
         isOnPageUnloadEnabled: true,
-        expectedOptions: RUN_BEHAVIOR_VALUES.filter(
+        expectedOptions: JS_OBJECT_RUN_BEHAVIOR_VALUES.filter(
           (option) => option.value !== ActionRunBehaviour.AUTOMATIC,
         ),
       },
       {
         isReactiveActionsEnabled: true,
         isOnPageUnloadEnabled: false,
-        expectedOptions: RUN_BEHAVIOR_VALUES.filter(
+        expectedOptions: JS_OBJECT_RUN_BEHAVIOR_VALUES.filter(
           (option) => option.value !== ActionRunBehaviour.ON_PAGE_UNLOAD,
         ),
       },
       {
         isReactiveActionsEnabled: false,
         isOnPageUnloadEnabled: false,
-        expectedOptions: RUN_BEHAVIOR_VALUES.filter(
+        expectedOptions: JS_OBJECT_RUN_BEHAVIOR_VALUES.filter(
           (option) =>
             option.value !== ActionRunBehaviour.AUTOMATIC &&
             option.value !== ActionRunBehaviour.ON_PAGE_UNLOAD,
@@ -65,11 +65,11 @@ describe("getRunBehaviorOptions", () => {
 
 describe("getDefaultRunBehaviorOptionWhenFeatureFlagIsDisabled", () => {
   const onPageLoadOption =
-    RUN_BEHAVIOR_VALUES.find(
+    JS_OBJECT_RUN_BEHAVIOR_VALUES.find(
       (option) => option.value === ActionRunBehaviour.ON_PAGE_LOAD,
     ) ?? null;
   const manualOption =
-    RUN_BEHAVIOR_VALUES.find(
+    JS_OBJECT_RUN_BEHAVIOR_VALUES.find(
       (option) => option.value === ActionRunBehaviour.MANUAL,
     ) ?? null;
 
@@ -141,7 +141,7 @@ describe("getDefaultRunBehaviorOptionWhenFeatureFlagIsDisabled", () => {
           runBehaviour,
           isReactiveActionsEnabled,
           isOnPageUnloadEnabled,
-          RUN_BEHAVIOR_VALUES,
+          JS_OBJECT_RUN_BEHAVIOR_VALUES,
         );
 
         expect(option).toEqual(expectedOption);

app/client/src/pages/Editor/JSEditor/JSEditorToolbar/components/utils.ts

@@ -2,7 +2,7 @@ import {
   ActionRunBehaviour,
   type ActionRunBehaviourType,
 } from "PluginActionEditor/types/PluginActionTypes";
-import { RUN_BEHAVIOR_VALUES } from "constants/AppsmithActionConstants/formConfig/PluginSettings";
+import { JS_OBJECT_RUN_BEHAVIOR_VALUES } from "constants/AppsmithActionConstants/formConfig/PluginSettings";
 
 import { type SelectOptionProps } from "@appsmith/ads";
 /**
@@ -14,7 +14,7 @@ export const getRunBehaviorOptionsBasedOnFeatureFlags = (
   isReactiveActionsEnabled: boolean,
   isOnPageUnloadEnabled: boolean,
 ) =>
-  RUN_BEHAVIOR_VALUES.filter(
+  JS_OBJECT_RUN_BEHAVIOR_VALUES.filter(
     (option) =>
       (isReactiveActionsEnabled ||
         option.value !== ActionRunBehaviour.AUTOMATIC) &&