Skip to content

Commit 59f9b9b

Browse files
committed
Merge remote-tracking branch 'origin/release' into fix/CVE-2025-58754
2 parents d1f2edb + ef79d5f commit 59f9b9b

File tree

6 files changed

+21
-93
lines changed

6 files changed

+21
-93
lines changed

app/client/src/pages/AppViewer/Navigation/components/BackToAppsButton.tsx

Lines changed: 12 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,8 @@ import { getCurrentUser } from "selectors/usersSelectors";
1414
import type { User } from "constants/userConstants";
1515
import { ANONYMOUS_USERNAME } from "constants/userConstants";
1616
import { Icon, Tooltip } from "@appsmith/ads";
17+
import { getCurrentWorkspaceId } from "ee/selectors/selectedWorkspaceSelectors";
18+
import { APPLICATIONS_URL } from "constants/routes";
1719

1820
interface BackToAppsButtonProps {
1921
currentApplicationDetails?: ApplicationPayload;
@@ -44,11 +46,20 @@ const BackToAppsButton = (props: BackToAppsButtonProps) => {
4446
);
4547
const history = useHistory();
4648
const currentUser: User | undefined = useSelector(getCurrentUser);
49+
const currentWorkspaceId = useSelector(getCurrentWorkspaceId);
4750

4851
if (currentUser?.username === ANONYMOUS_USERNAME) {
4952
return null;
5053
}
5154

55+
const handleNavigation = () => {
56+
const applicationsUrl = currentWorkspaceId
57+
? `${APPLICATIONS_URL}?workspaceId=${currentWorkspaceId}`
58+
: APPLICATIONS_URL;
59+
60+
history.push(applicationsUrl);
61+
};
62+
5263
return (
5364
<Tooltip
5465
content={createMessage(ALL_APPS)}
@@ -69,9 +80,7 @@ const BackToAppsButton = (props: BackToAppsButtonProps) => {
6980
insideSidebar={insideSidebar}
7081
isMinimal={isMinimal}
7182
navColorStyle={navColorStyle}
72-
onClick={() => {
73-
history.push("/applications");
74-
}}
83+
onClick={handleNavigation}
7584
primaryColor={primaryColor}
7685
text={insideSidebar && !isMinimal && createMessage(ALL_APPS)}
7786
/>

app/client/src/pages/Editor/AppsmithLink.tsx

Lines changed: 9 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,7 @@ import AppsmithLogo from "assets/images/appsmith_logo_square.png";
77
import history from "utils/history";
88
import { useSelector } from "react-redux";
99
import { getOrganizationConfig } from "ee/selectors/organizationSelectors";
10+
import { getCurrentWorkspaceId } from "ee/selectors/selectedWorkspaceSelectors";
1011

1112
export const StyledLink = styled((props) => {
1213
// we are removing non input related props before passing them in the components
@@ -27,18 +28,23 @@ export const StyledLink = styled((props) => {
2728

2829
export const AppsmithLink = () => {
2930
const organizationConfig = useSelector(getOrganizationConfig);
31+
const currentWorkspaceId = useSelector(getCurrentWorkspaceId);
3032

3133
const handleOnClick = useCallback(
3234
(e: React.MouseEvent<HTMLAnchorElement>) => {
3335
e.stopPropagation();
3436

37+
const applicationsUrl = currentWorkspaceId
38+
? `${APPLICATIONS_URL}?workspaceId=${currentWorkspaceId}`
39+
: APPLICATIONS_URL;
40+
3541
if (e.ctrlKey || e.metaKey) {
36-
window.open(APPLICATIONS_URL, "_blank");
42+
window.open(applicationsUrl, "_blank");
3743
} else {
38-
history.push(APPLICATIONS_URL);
44+
history.push(applicationsUrl);
3945
}
4046
},
41-
[],
47+
[currentWorkspaceId],
4248
);
4349

4450
return (

app/server/appsmith-server/src/main/java/com/appsmith/server/controllers/ConfigController.java

Lines changed: 0 additions & 16 deletions
This file was deleted.

app/server/appsmith-server/src/main/java/com/appsmith/server/controllers/ce/ConfigControllerCE.java

Lines changed: 0 additions & 37 deletions
This file was deleted.

app/server/appsmith-server/src/main/java/com/appsmith/server/services/ce/ConfigServiceCE.java

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,6 @@
11
package com.appsmith.server.services.ce;
22

3-
import com.appsmith.server.acl.AclPermission;
43
import com.appsmith.server.domains.Config;
5-
import com.appsmith.server.domains.User;
64
import reactor.core.publisher.Mono;
75

86
import java.util.Map;
@@ -11,8 +9,6 @@ public interface ConfigServiceCE {
119

1210
Mono<Config> getByName(String name);
1311

14-
Mono<Config> updateByName(Config config);
15-
1612
Mono<Config> save(Config config);
1713

1814
Mono<Config> save(String name, Map<String, Object> config);
@@ -21,10 +17,6 @@ public interface ConfigServiceCE {
2117

2218
Mono<Void> delete(String name);
2319

24-
Mono<Config> getByName(String name, AclPermission permission);
25-
26-
Mono<Config> getByNameAsUser(String name, User user, AclPermission permission);
27-
2820
/**
2921
* Get the instance variables from the instance config
3022
* @return Map containing the instance variables

app/server/appsmith-server/src/main/java/com/appsmith/server/services/ce/ConfigServiceCEImpl.java

Lines changed: 0 additions & 26 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,7 @@
11
package com.appsmith.server.services.ce;
22

3-
import com.appsmith.server.acl.AclPermission;
43
import com.appsmith.server.constants.FieldName;
54
import com.appsmith.server.domains.Config;
6-
import com.appsmith.server.domains.User;
75
import com.appsmith.server.exceptions.AppsmithError;
86
import com.appsmith.server.exceptions.AppsmithException;
97
import com.appsmith.server.repositories.ConfigRepository;
@@ -34,20 +32,6 @@ public Mono<Config> getByName(String name) {
3432
Mono.error(new AppsmithException(AppsmithError.NO_RESOURCE_FOUND, FieldName.CONFIG, name)));
3533
}
3634

37-
@Override
38-
public Mono<Config> updateByName(Config config) {
39-
final String name = config.getName();
40-
return repository
41-
.findByName(name)
42-
.switchIfEmpty(
43-
Mono.error(new AppsmithException(AppsmithError.NO_RESOURCE_FOUND, FieldName.CONFIG, name)))
44-
.flatMap(dbConfig -> {
45-
log.debug("Found config with name: {} and id: {}", name, dbConfig.getId());
46-
dbConfig.setConfig(config.getConfig());
47-
return repository.save(dbConfig);
48-
});
49-
}
50-
5135
@Override
5236
public Mono<Config> save(Config config) {
5337
return repository
@@ -85,16 +69,6 @@ public Mono<Void> delete(String name) {
8569
.flatMap(repository::delete);
8670
}
8771

88-
@Override
89-
public Mono<Config> getByName(String name, AclPermission permission) {
90-
return repository.findByName(name, permission);
91-
}
92-
93-
@Override
94-
public Mono<Config> getByNameAsUser(String name, User user, AclPermission permission) {
95-
return repository.findByNameAsUser(name, user, permission);
96-
}
97-
9872
@Override
9973
public Mono<Map<String, Object>> getInstanceVariables() {
10074
return getByName(FieldName.INSTANCE_CONFIG).map(config -> {

0 commit comments

Comments
 (0)