Commit 848e428
authored
deprecate NIOEventLoopGroupProvider.createNew (#2480)
### Motivation:
`NIOEventLoopGroupProvider.createNew` was probably never a good idea
because it creates shutdown issues for any library that uses it. Given
that we now have singleton (#2471) `EventLoopGroup`s, we can solve this
issue by just not having event loop group providers.
Users can just use `group: any EventLoopGroup` and optionally `group:
any EventLoopGroup = MultiThreadedEventLoopGroup.singleton`.
### Modifications:
- deprecate `NIOEventLoopGroupProvider.createNew`
- soft-deprecate (document as deprecated but don't mark
`@available(deprecated)`) `NIOEventLoopGroupProvider`
### Result:
- Libraries becomes easier to write and maintain.
- Fixes #21421 parent 6ba8f4f commit 848e428
2 files changed
+19
-3
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
21 | 21 | | |
22 | 22 | | |
23 | 23 | | |
24 | | - | |
25 | 24 | | |
26 | 25 | | |
27 | 26 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1246 | 1246 | | |
1247 | 1247 | | |
1248 | 1248 | | |
1249 | | - | |
| 1249 | + | |
| 1250 | + | |
| 1251 | + | |
1250 | 1252 | | |
1251 | 1253 | | |
| 1254 | + | |
| 1255 | + | |
| 1256 | + | |
| 1257 | + | |
| 1258 | + | |
| 1259 | + | |
1252 | 1260 | | |
1253 | 1261 | | |
1254 | 1262 | | |
1255 | 1263 | | |
1256 | | - | |
| 1264 | + | |
| 1265 | + | |
1257 | 1266 | | |
1258 | 1267 | | |
| 1268 | + | |
| 1269 | + | |
| 1270 | + | |
| 1271 | + | |
| 1272 | + | |
| 1273 | + | |
| 1274 | + | |
| 1275 | + | |
1259 | 1276 | | |
1260 | 1277 | | |
1261 | 1278 | | |
| |||
0 commit comments