Skip to content

feat: add xctest class which can be used to start WDA#110

Merged
mykola-mokhnach merged 26 commits into
appium:masterfrom
tomriddly:master
Apr 14, 2023
Merged

feat: add xctest class which can be used to start WDA#110
mykola-mokhnach merged 26 commits into
appium:masterfrom
tomriddly:master

Conversation

@tomriddly
Copy link
Copy Markdown
Collaborator

@tomriddly tomriddly commented Apr 10, 2023

Code is tested using real device. This is capable of launching WDA along with a additional iproxy process which is not implemented in this library for now.

I'm not sure if xctest.js is placed at a appropriate folder. It's not a utility or service, and it uses lots of predefined service. Eventually I put it as a independent file under lib.

tomriddly added 9 commits April 7, 2023 11:58
@tomriddly
fix: callMessage could not handle auxBuffer correctly
5360770 
Signed-off-by: tomriddly <[email protected]>
@tomriddly
feat: add testmanagerd service based on instrment service.
9448053 
Signed-off-by: tomriddly <[email protected]>
@tomriddly
fix: issues from code review
4d9f74f 
Signed-off-by: tomriddly <[email protected]>
@tomriddly
Merge branch 'appium:master' into master
be2b951
@tomriddly
feat: add defination of XCTestConfiguration and XCActivityRecord.
b0fbbb5 
Signed-off-by: tomriddly <[email protected]>
@tomriddly
fix: invalid output of archived plist which cases .xctestconfiguratio…
ecc1f92 
…n not parsed by testmanagerd

Signed-off-by: tomriddly <[email protected]>
@tomriddly
fix: changed selector in reply could break continuous procedure
a044d9d 
Signed-off-by: tomriddly <[email protected]>
@tomriddly
feat: add getBytes() for XCTestConfiguration
64ef106 
Signed-off-by: tomriddly <[email protected]>
@tomriddly
feat: add xctest
cd31269 
Signed-off-by: tomriddly <[email protected]>
@tomriddly
Copy link
Copy Markdown
Collaborator Author

tomriddly commented Apr 10, 2023

I could write the documents if the proper folder and export of xctest is decided

KazuCocoa
KazuCocoa reviewed Apr 10, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@KazuCocoa KazuCocoa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. I think xctest is fine in the lib. Left a couple of comments I was awarded of at first glance. I'll read later further.

Comment thread lib/xctest.js Outdated
Comment thread lib/instrument/transformer/nskeyed.js
Comment thread lib/instrument/transformer/nskeyed.js
Comment thread lib/xctest.js Outdated
Comment thread lib/xctest.js Outdated
Comment thread lib/xctest.js Outdated
@tomriddly
Copy link
Copy Markdown
Collaborator Author

tomriddly commented Apr 10, 2023

Successfully tested on iOS 16/15，but got a failure on 13.6.1.

mykola-mokhnach
mykola-mokhnach reviewed Apr 10, 2023
View reviewed changes
Comment thread lib/instrument/index.js
mykola-mokhnach
mykola-mokhnach reviewed Apr 10, 2023
View reviewed changes
Comment thread lib/instrument/transformer/nskeyed.js Outdated
mykola-mokhnach
mykola-mokhnach reviewed Apr 10, 2023
View reviewed changes
Comment thread lib/instrument/transformer/nskeyed.js Outdated
mykola-mokhnach
mykola-mokhnach reviewed Apr 10, 2023
View reviewed changes
Comment thread lib/instrument/transformer/nskeyed.js Outdated
mykola-mokhnach
mykola-mokhnach reviewed Apr 10, 2023
View reviewed changes
Comment thread lib/instrument/transformer/nskeyed.js
mykola-mokhnach
mykola-mokhnach reviewed Apr 10, 2023
View reviewed changes
Comment thread lib/instrument/transformer/nskeyed.js Outdated
mykola-mokhnach
mykola-mokhnach reviewed Apr 10, 2023
View reviewed changes
Comment thread lib/instrument/transformer/nskeyed.js Outdated
mykola-mokhnach
mykola-mokhnach reviewed Apr 10, 2023
View reviewed changes
Comment thread lib/instrument/transformer/nskeyed.js Outdated
mykola-mokhnach
mykola-mokhnach reviewed Apr 10, 2023
View reviewed changes
Comment thread lib/instrument/transformer/nskeyed.js Outdated
mykola-mokhnach
mykola-mokhnach reviewed Apr 10, 2023
View reviewed changes
Comment thread lib/instrument/transformer/nskeyed.js Outdated
mykola-mokhnach
mykola-mokhnach reviewed Apr 10, 2023
View reviewed changes
Comment thread lib/instrument/transformer/nskeyed.js Outdated
mykola-mokhnach
mykola-mokhnach reviewed Apr 10, 2023
View reviewed changes
Comment thread lib/xctest.js Outdated
mykola-mokhnach
mykola-mokhnach reviewed Apr 10, 2023
View reviewed changes
Comment thread lib/xctest.js Outdated
mykola-mokhnach
mykola-mokhnach reviewed Apr 10, 2023
View reviewed changes
Comment thread lib/xctest.js Outdated
KazuCocoa
KazuCocoa reviewed Apr 12, 2023
View reviewed changes
Comment thread lib/xctest.js Outdated
@tomriddly
Copy link
Copy Markdown
Collaborator Author

tomriddly commented Apr 12, 2023

So many constants and string issue.
These are mostly from a debug procedure and should not be committed as final code.
Deeply sorry wasting @mykola-mokhnach 's time for these annoying code. I will make a cleanup.

It is not a problem at all. Main thing we can make it better together. Not even saying about your background investigation in order to reverse engineer and test the approach. @tomriddly, are you interested in becoming the maintainer of this module? Unfortunately we do not have people in our team who have deep knowledge of this topic.

I'm not familiar with these stuff. What are the responsibilities of module maintainer? I do have some knowledges about this, but I'm not sure if I'm qualified

The responsibilities are not strict. It is usually necessary to make sure the module still works after a new iOS/Xcode version is released, check/triage possible user issues, and review incoming PRs.

Sounds good to me.
I think I could do this as part-time.
What else operations should I do? like join appium organization? or just waiting for a @tomriddly in issue and pr?

@mykola-mokhnach
Copy link
Copy Markdown
Contributor

mykola-mokhnach commented Apr 12, 2023

Sounds good to me. I think I could do this as part-time. What else operations should I do? like join appium organization? or just waiting for a @tomriddly in issue and pr?

Nothing special. You could join our Slack to discuss dev topics (simply send me your email and you'll get an invitation) and enable watching issues on this repository.

mykola-mokhnach
mykola-mokhnach reviewed Apr 12, 2023
View reviewed changes
Comment thread README.md Outdated
mykola-mokhnach
mykola-mokhnach reviewed Apr 12, 2023
View reviewed changes
Comment thread README.md
mykola-mokhnach
mykola-mokhnach reviewed Apr 12, 2023
View reviewed changes
Comment thread lib/instrument/transformer/nskeyed.js Outdated
mykola-mokhnach
mykola-mokhnach reviewed Apr 12, 2023
View reviewed changes
Comment thread lib/instrument/index.js Outdated
mykola-mokhnach
mykola-mokhnach reviewed Apr 12, 2023
View reviewed changes
Comment thread lib/xctest.js Outdated
mykola-mokhnach
mykola-mokhnach reviewed Apr 12, 2023
View reviewed changes
Comment thread lib/xctest.js
mykola-mokhnach
mykola-mokhnach reviewed Apr 12, 2023
View reviewed changes
Comment thread lib/xctest.js
mykola-mokhnach
mykola-mokhnach reviewed Apr 12, 2023
View reviewed changes
Comment thread lib/xctest.js
@mykola-mokhnach mykola-mokhnach merged commit f3740fd into appium:master Apr 14, 2023
github-actions Bot pushed a commit that referenced this pull request Apr 14, 2023
@semantic-release-bot
chore(release): 2.5.0 [skip ci]
ba7c5cd 
## [2.5.0](v2.4.12...v2.5.0) (2023-04-14)

### Features

* add xctest class which can be used to start WDA ([#110](#110)) ([f3740fd](f3740fd))
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 14, 2023

🎉 This PR is included in version 2.5.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@KazuCocoa KazuCocoa mentioned this pull request Apr 15, 2023
Closed
tomriddly added a commit that referenced this pull request Apr 18, 2023
@tomriddly
feat: add xctest class which can be used to start WDA (#110)
4d2226f
tomriddly pushed a commit that referenced this pull request Apr 18, 2023
@semantic-release-bot
chore(release): 2.5.0 [skip ci]
b17e954 
## [2.5.0](v2.4.12...v2.5.0) (2023-04-14)

### Features

* add xctest class which can be used to start WDA ([#110](#110)) ([f3740fd](f3740fd))
@eyJhb eyJhb mentioned this pull request May 15, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mykola-mokhnach mykola-mokhnach mykola-mokhnach approved these changes

@KazuCocoa KazuCocoa Awaiting requested review from KazuCocoa

Assignees

No one assigned

Labels

released

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@tomriddly @mykola-mokhnach @KazuCocoa