Defend against non-serializable params in invariantWrappers (#11861)

Author: henryqdineen

.changeset/little-weeks-join.md

@@ -0,0 +1,5 @@
+---
+"@apollo/client": patch
+---
+
+Defend against non-serializable params in `invariantWrappers`

.size-limits.json

@@ -1,4 +1,4 @@
 {
-  "dist/apollo-client.min.cjs": 39581,
-  "import { ApolloClient, InMemoryCache, HttpLink } from \"dist/index.js\" (production)": 32830
+  "dist/apollo-client.min.cjs": 39604,
+  "import { ApolloClient, InMemoryCache, HttpLink } from \"dist/index.js\" (production)": 32852
 }

src/utilities/globals/__tests__/invariantWrappers.test.ts

@@ -171,3 +171,25 @@ test("base invariant(false, 6, ...), raises fallback", async () => {
     )
   );
 });
+
+test("base invariant(false, 6, ...) with non-serializable param", async () => {
+  await using _ = mockErrorMessageHandler();
+
+  const obj: any = {};
+  obj.self = obj;
+
+  expect(() => {
+    invariant(false, 6, obj);
+  }).toThrow(
+    new InvariantError(
+      "An error occurred! For more details, see the full error text at https://go.apollo.dev/c/err#" +
+        encodeURIComponent(
+          JSON.stringify({
+            version: "local",
+            message: 6,
+            args: ["<non-serializable>"],
+          })
+        )
+    )
+  );
+});

src/utilities/globals/invariantWrappers.ts

@@ -117,9 +117,15 @@ declare global {
 }
 
 function stringify(arg: any) {
-  return typeof arg == "string" ? arg : (
-      stringifyForDisplay(arg, 2).slice(0, 1000)
-    );
+  if (typeof arg == "string") {
+    return arg;
+  }
+
+  try {
+    return stringifyForDisplay(arg, 2).slice(0, 1000);
+  } catch {
+    return "<non-serializable>";
+  }
 }
 
 function getHandledErrorMsg(