Cleanup

Author: karthikiyengar

src/application/components/Layouts/Navigation.tsx

@@ -119,7 +119,6 @@ export const Navigation: React.FC<NavigationProps> = ({
           target="_blank"
           title="Apollo Client developer documentation"
           css={logoLinkStyles}
-          rel="noreferrer"
         >
           <ApolloLogo css={logoStyles} />
         </a>

src/application/index.tsx

@@ -1,4 +1,5 @@
 /** @jsx jsx */
+
 import React from "react";
 import { useEffect } from "react";
 import { jsx } from "@emotion/react";

src/extension/background/background.ts

@@ -17,8 +17,12 @@ chrome.runtime.onConnect.addListener(port => {
     try {
       port.postMessage(message);
     } catch {
+      /*
+      * With multiple frames, we receive a onDisconnect event twice,
+      * resulting in stale ports. Without the try/catch, we drop
+      * legitimate messages as well.
+      */
       console.error('Error sending message to ' + port.name)
-      // do nothing as we don't care about dead ports - think about this again
     }
   });
 

src/extension/tab/hook.ts

@@ -47,14 +47,6 @@ type Hook = {
   getCache: () => void;
 };
 
-function inIframe () {
-  try {
-      return window.self !== window.top;
-  } catch (e) {
-      return true;
-  }
-}
-
 const apolloClientId = cuid();
 
 function initializeHook() {