optimize: pre check dataChangeCreatedBy in updateItem

k8scat · nobodyiam · commit 8acf07510c1e · 2025-01-18T19:33:19.000+08:00
diff --git a/apollo-portal/src/main/java/com/ctrip/framework/apollo/openapi/v1/controller/ItemController.java b/apollo-portal/src/main/java/com/ctrip/framework/apollo/openapi/v1/controller/ItemController.java
@@ -123,6 +123,9 @@ public void updateItem(@PathVariable String appId, @PathVariable String env,
     }
 
     if (createIfNotExists) {
+      if (StringUtils.isEmpty(item.getDataChangeCreatedBy())) {
+        throw new BadRequestException("dataChangeCreatedBy is required when createIfNotExists is true");
+      }
       this.itemOpenApiService.createOrUpdateItem(appId, env, clusterName, namespaceName, item);
     } else {
       this.itemOpenApiService.updateItem(appId, env, clusterName, namespaceName, item);

Original file line number	Diff line number	Diff line change
`@@ -123,6 +123,9 @@ public void updateItem(@PathVariable String appId, @PathVariable String env,`
`123`	`123`	`}`
`124`	`124`
`125`	`125`	`if (createIfNotExists) {`
	`126`	`+ if (StringUtils.isEmpty(item.getDataChangeCreatedBy())) {`
	`127`	`+ throw new BadRequestException("dataChangeCreatedBy is required when createIfNotExists is true");`
	`128`	`+ }`
`126`	`129`	`this.itemOpenApiService.createOrUpdateItem(appId, env, clusterName, namespaceName, item);`
`127`	`130`	`} else {`
`128`	`131`	`this.itemOpenApiService.updateItem(appId, env, clusterName, namespaceName, item);`