Fix garbage component issue of ruby-saml and rexml#202
Open
klouvas wants to merge 1 commit intoapokalipto:masterfrom
Open
Fix garbage component issue of ruby-saml and rexml#202klouvas wants to merge 1 commit intoapokalipto:masterfrom
klouvas wants to merge 1 commit intoapokalipto:masterfrom
Conversation
Collaborator
|
Hi @klouvas, thanks for the contribution! I don't think this requires a fix on our end—applications can update their version of ruby-saml without needing to update this gem. |
Author
|
@adamstegman It could be resolved by manually bumping the |
Collaborator
|
If there's a security issue, definitely! But for anything else, it's not our responsibility, and in fact we'd be breaking compatibility with applications using older versions of ruby-saml. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue: #201