Skip to content

Conversation

@Pijukatel
Copy link
Collaborator

@Pijukatel Pijukatel commented Nov 21, 2024

Lock pydantic to version ~2.9.0
New fresh version 2.10.0 has many unresolved issues that break our codebase.

@github-actions github-actions bot added this to the 103rd sprint - Tooling team milestone Nov 21, 2024
@github-actions github-actions bot added the t-tooling Issues with this label are in the ownership of the tooling team. label Nov 21, 2024
@Pijukatel Pijukatel changed the title First test that 2.10.0 is failing even in unit tests fix: Pydantic 2.10.0 issues Nov 21, 2024
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Pull Request Tookit has failed!

Pull request is neither linked to an issue or epic nor labeled as adhoc!

Fresh release of 2.10.0 breaks code base.
@Pijukatel Pijukatel added the adhoc Ad-hoc unplanned task added during the sprint. label Nov 21, 2024
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Pull Request Tookit has failed!

Pull request is neither linked to an issue or epic nor labeled as adhoc!

Fresh release of 2.10.0 breaks code base.
@Pijukatel Pijukatel requested a review from janbuchar November 21, 2024 10:06
@Pijukatel Pijukatel marked this pull request as ready for review November 21, 2024 10:06
Fresh release of 2.10.0 breaks code base.
@Pijukatel Pijukatel requested a review from B4nan November 21, 2024 10:29
Copy link
Collaborator

@vdusek vdusek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are you updating the lockfile? Add an upper bound to Pydantic should be enough, correct?

Copy link
Collaborator

@vdusek vdusek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, let's go

@Pijukatel Pijukatel merged commit 8d8b3fc into master Nov 21, 2024
23 checks passed
@Pijukatel Pijukatel deleted the pydantic-2-10-0-issues branch November 21, 2024 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

adhoc Ad-hoc unplanned task added during the sprint. t-tooling Issues with this label are in the ownership of the tooling team.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants