-
Notifications
You must be signed in to change notification settings - Fork 514
feat: Add always_enqueue option to bypass URL deduplication
#621
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@vdusek I have reviewed this issue and your suggestions and implemented them in this PR. Please review and suggest changes, if any. Thanks. cc; @janbuchar |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks quite good, but make sure the CI passes (lint check, type check, unit tests... all are failing), see the CONTRIBUTING.md for more information.
Co-authored-by: Vlada Dusek <[email protected]>
|
@vdusek Please run the CI checks again. I have pushed a commit to fix them all. Thanks. cc: @souravjain540 |
janbuchar
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you for your contribution!
Description
This PR implements a new input parameter, always_enqueue, in the Request.from_url constructor. This feature allows users to bypass the request deduplication process, ensuring that each request is always enqueued and processed.
Key Changes:
With this addition, users can seamlessly manage their requests while maintaining flexibility in their queuing strategy.
Issues
Fixes #547
Testing
The modifications can be verified by making requests to the same URL. The operations should execute each time this is done without treating it as a duplicate request when
always_enqueueis set to true.Checklist