feat: Add RQ id, name, alias args to add_requests and enqueue_links methods
#1413
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vdusek
reviewed
Sep 19, 2025
Collaborator
vdusek
left a comment
vdusek
left a comment
There was a problem hiding this comment.
Should we also include rq_id?
My thinking was that this should apply only to the context-level helpers, not the crawler-level ones. At the crawler level, they should always use the crawler's configured request manager.
Collaborator
Author
Yes, I think we should, for consistency of supported parameters. Added
Yes, this PR adds support for new parameters, specifically in helpers. |
vdusek
requested changes
Sep 21, 2025
Collaborator
vdusek
left a comment
vdusek
left a comment
There was a problem hiding this comment.
Just a few details, my comments apply to their other occurrences as well.
Co-authored-by: Vlada Dusek <[email protected]>
Co-authored-by: Vlada Dusek <[email protected]>
vdusek
changed the title
rq_name and rq_alias params for add_requests and enqueue_links methodsadd_requests and enqueue_links methods
Pijukatel
approved these changes
Sep 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
add_requestsandenqueue_linksmethodsIssues
add_requestsandenqueue_linksmethods #1402