fix: respect KVS.getPublicUrl() from core when not on apify platform
#302
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
t-tooling
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Pull request is neither linked to an issue or epic nor labeled as adhoc!
barjin
added a commit
that referenced
this pull request
Sep 9, 2025
The original check from #302 was not sufficient. When the user passes `forceCloud: true` to `KVS.open()`, the SDK instance points to a platform-backed KVS, even if the script is run locally. This PR proposes checking the runtime type of `KeyValueStore.client`. If this is a client instance from `apify-client`, we're communicating with the platform, regardless of the place of execution (Platform / locally). Closes #459
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Crawlee 3.10+ now implements the
getPublicUrl()too, returning local file URL pointing to the memory storage file.This PR handles changes the SDK variant of
getPublicUrl()to use that when outside of the apify platform instead of always returning the platform path (just because the SDK gets imported).