Skip to content

fix: url shortener invalid input #13461

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 4, 2021
Merged

fix: url shortener invalid input #13461

merged 2 commits into from
Mar 4, 2021

Conversation

@dpgaspar
Copy link
Member

@dpgaspar dpgaspar commented Mar 4, 2021

SUMMARY

Make url shortener API only accept url's to defined/expected locations on superset.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Requires DB Migration.
  • Confirm DB Migration upgrade and downgrade tested.
  • Introduces new feature or API
  • Removes existing feature or API

@dpgaspar dpgaspar requested a review from willbarrett March 4, 2021 14:34
villebro
villebro approved these changes Mar 4, 2021
View reviewed changes
Copy link
Member

@villebro villebro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Mar 4, 2021 •
edited
Loading

Codecov Report

Merging #13461 (df5e0b1) into master (6026e7d) will decrease coverage by 0.98%.
The diff coverage is 88.57%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #13461      +/-   ##
==========================================
- Coverage   72.74%   71.75%   -0.99%     
==========================================
  Files         906      804     -102     
  Lines       45654    40623    -5031     
  Branches     5516     4157    -1359     
==========================================
- Hits        33212    29150    -4062     
+ Misses      12232    11473     -759     
+ Partials      210        0     -210
Flag Coverage Δ
cypress 57.94% <84.21%> (?)
hive 80.01% <93.75%> (+0.02%) ⬆️
javascript ?
mysql 80.34% <93.75%> (+0.02%) ⬆️
postgres 80.38% <93.75%> (+0.02%) ⬆️
presto 80.05% <93.75%> (+0.02%) ⬆️
python 80.89% <93.75%> (+0.02%) ⬆️
sqlite 80.00% <93.75%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...hboard/components/menu/BackgroundStyleDropdown.tsx 0.00% <0.00%> (ø)
...dashboard/components/menu/MarkdownModeDropdown.tsx 100.00% <ø> (ø)
.../src/dashboard/components/menu/PopoverDropdown.tsx 65.00% <85.71%> (ø)
superset/views/redirects.py 88.37% <92.85%> (+18.37%) ⬆️
...ontend/src/dashboard/components/menu/HoverMenu.tsx 100.00% <100.00%> (ø)
.../src/dashboard/components/menu/WithPopoverMenu.tsx 81.25% <100.00%> (ø)
superset/dashboards/schemas.py 98.87% <100.00%> (+0.02%) ⬆️
...uperset-frontend/src/dashboard/util/dnd-reorder.js 0.00% <0.00%> (-100.00%) ⬇️
...rset-frontend/src/dashboard/util/getEmptyLayout.js 0.00% <0.00%> (-100.00%) ⬇️
...et-frontend/src/components/Pagination/Ellipsis.tsx 0.00% <0.00%> (-100.00%) ⬇️
... and 529 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6026e7d...d864577. Read the comment docs.

@dpgaspar dpgaspar merged commit c3c7376 into apache:master Mar 4, 2021
@dpgaspar dpgaspar deleted the fix/redirect-endpoint branch March 4, 2021 20:46
henryyeh pushed a commit to preset-io/superset that referenced this pull request Mar 4, 2021
@dpgaspar
fix: url shortener invalid input (apache#13461)
a636b35 
* fix: url shortner invalid input

* fix lint

(cherry picked from commit c3c7376)
betodealmeida pushed a commit to betodealmeida/incubator-superset that referenced this pull request Mar 19, 2021
@dpgaspar @betodealmeida
fix: url shortener invalid input (apache#13461)
eb35b80 
* fix: url shortner invalid input

* fix lint
@westonsteimel westonsteimel mentioned this pull request May 22, 2022
Merged
cccs-rc pushed a commit to CybercentreCanada/superset that referenced this pull request Mar 6, 2024
@dpgaspar @betodealmeida
fix: url shortener invalid input (apache#13461)
f742a5d 
* fix: url shortner invalid input

* fix lint
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.2.0 First shipped in 1.2.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@robdiciuccio robdiciuccio robdiciuccio approved these changes

@craig-rueda craig-rueda craig-rueda approved these changes

@villebro villebro villebro approved these changes

@willbarrett willbarrett Awaiting requested review from willbarrett

Assignees

No one assigned

Labels

🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels preset-io size/M v1.1 🚢 1.2.0 First shipped in 1.2.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@dpgaspar @robdiciuccio @craig-rueda @villebro @mistercrunch