Replace File.createTempFile with java.nio.file.Files.createTempFile

Signed-off-by: Julien Nioche <[email protected]>

Author: jnioche

examples/storm-pmml-examples/src/main/java/org/apache/storm/pmml/JpmmlRunnerTestTopology.java

@@ -24,6 +24,7 @@
 import java.io.FileOutputStream;
 import java.io.IOException;
 import java.io.InputStream;
+import java.nio.file.Files;
 import java.util.Arrays;
 import java.util.List;
 
@@ -131,7 +132,7 @@ private void setDefaults() {
 
     private File loadExample(File file, String example) {
         try (InputStream stream = Thread.currentThread().getContextClassLoader().getResourceAsStream(example)) {
-            file = File.createTempFile("pmml-example", ".tmp");
+            file = Files.createTempFile("pmml-example", ".tmp").toFile();
             IOUtils.copy(stream, new FileOutputStream(file));
         } catch (IOException e) {
             throw new RuntimeException("Error loading example " + example, e);

storm-client/test/jvm/org/apache/storm/dependency/DependencyUploaderTest.java

@@ -301,7 +301,7 @@ public void uploadArtifacts() throws Exception {
     }
 
     private File createTemporaryDummyFile() throws IOException {
-        File tempFile = File.createTempFile("tempfile", ".tmp");
+        File tempFile = java.nio.file.Files.createTempFile("tempfile", ".tmp").toFile();
 
         BufferedWriter bw = new BufferedWriter(new FileWriter(tempFile));
         bw.write("This is the temporary file content");

storm-client/test/jvm/org/apache/storm/security/auth/AutoSSLTest.java

@@ -73,7 +73,7 @@ public void testgetSSLFilesFromConfMultipleComma() {
 
     @Test
     public void testpopulateCredentials() throws Exception {
-        File temp = File.createTempFile("tmp-autossl-test", ".txt");
+        File temp = Files.createTempFile("tmp-autossl-test", ".txt").toFile();
         temp.deleteOnExit();
         List<String> lines = Arrays.asList("The first line", "The second line");
         Files.write(temp.toPath(), lines, StandardCharsets.UTF_8);

storm-client/test/jvm/org/apache/storm/security/auth/authorizer/DRPCSimpleACLAuthorizerTest.java

@@ -16,6 +16,7 @@
 import java.io.File;
 import java.io.FileWriter;
 import java.io.IOException;
+import java.nio.file.Files;
 import java.util.HashMap;
 import java.util.Map;
 import org.apache.storm.Config;
@@ -175,7 +176,7 @@ private boolean isPermitted(IAuthorizer authorizer, ReqContext context, String o
     public void test_read_acl_no_values() throws IOException {
         DRPCSimpleACLAuthorizer authorizer = new DRPCSimpleACLAuthorizer();
 
-        File tempFile = File.createTempFile("drpcacl", ".yaml");
+        File tempFile = Files.createTempFile("drpcacl", ".yaml").toFile();
         tempFile.deleteOnExit();
         BufferedWriter writer = new BufferedWriter(new FileWriter(tempFile));
         writer.write("drpc.authorizer.acl:");
@@ -197,7 +198,7 @@ public void test_read_acl_no_values() throws IOException {
     public void test_read_acl_empty_file() throws IOException {
         DRPCSimpleACLAuthorizer authorizer = new DRPCSimpleACLAuthorizer();
 
-        File tempFile = File.createTempFile("drpcacl", ".yaml");
+        File tempFile = Files.createTempFile("drpcacl", ".yaml").toFile();
         tempFile.deleteOnExit();
 
         authorizer.prepare(ImmutableMap

storm-core/src/jvm/org/apache/storm/utils/TopologySpoutLag.java

@@ -21,6 +21,7 @@
 import java.io.File;
 import java.io.FileOutputStream;
 import java.io.IOException;
+import java.nio.file.Files;
 import java.util.ArrayList;
 import java.util.Arrays;
 import java.util.HashMap;
@@ -96,7 +97,7 @@ private static File createExtraPropertiesFile(Map<String, Object> jsonConf) {
         }
         if (!extraProperties.isEmpty()) {
             try {
-                file = File.createTempFile("kafka-consumer-extra", "props");
+                file = Files.createTempFile("kafka-consumer-extra", "props").toFile();
                 file.deleteOnExit();
                 Properties properties = new Properties();
                 properties.putAll(extraProperties);

storm-server/src/test/java/org/apache/storm/scheduler/utils/FileConfigLoaderTest.java

@@ -14,6 +14,7 @@
 
 import java.io.File;
 import java.io.FileWriter;
+import java.nio.file.Files;
 import java.util.HashMap;
 import java.util.Map;
 import org.apache.storm.Config;
@@ -49,7 +50,7 @@ public void testInvalidConfig() {
     @Test
     public void testMalformedYaml() throws Exception {
 
-        File temp = File.createTempFile("FileLoader", ".yaml");
+        File temp = Files.createTempFile("FileLoader", ".yaml").toFile();
         temp.deleteOnExit();
 
         FileWriter fw = new FileWriter(temp);
@@ -69,7 +70,7 @@ public void testMalformedYaml() throws Exception {
     @Test
     public void testValidFile() throws Exception {
 
-        File temp = File.createTempFile("FileLoader", ".yaml");
+        File temp = Files.createTempFile("FileLoader", ".yaml").toFile();
         temp.deleteOnExit();
 
         Map<String, Integer> testMap = new HashMap<>();