|
17 | 17 |
|
18 | 18 | package org.apache.spark.sql.catalyst.plans.logical |
19 | 19 |
|
20 | | -import org.apache.spark.sql.catalyst.{AliasIdentifier} |
| 20 | +import org.apache.spark.sql.catalyst.AliasIdentifier |
21 | 21 | import org.apache.spark.sql.catalyst.analysis.{MultiInstanceRelation, NamedRelation} |
22 | 22 | import org.apache.spark.sql.catalyst.catalog.{CatalogStorageFormat, CatalogTable} |
23 | 23 | import org.apache.spark.sql.catalyst.expressions._ |
24 | | -import org.apache.spark.sql.catalyst.expressions.aggregate.AggregateExpression |
| 24 | +import org.apache.spark.sql.catalyst.expressions.aggregate.{AggregateExpression, AggregateFunction} |
25 | 25 | import org.apache.spark.sql.catalyst.plans._ |
26 | 26 | import org.apache.spark.sql.catalyst.plans.physical.{HashPartitioning, Partitioning, RangePartitioning, RoundRobinPartitioning} |
27 | 27 | import org.apache.spark.sql.catalyst.util.truncatedString |
@@ -580,12 +580,11 @@ case class Range( |
580 | 580 | * |
581 | 581 | * @param groupingExpressions expressions for grouping keys |
582 | 582 | * @param aggregateExpressions expressions for a project list, which could contain |
583 | | - * [[org.apache.spark.sql.catalyst.expressions.aggregate.AggregateFunction]]s. |
| 583 | + * [[AggregateFunction]]s. |
584 | 584 | * |
585 | | - * Note: Currently, aggregateExpressions correspond to both [[AggregateExpression]] and the output |
586 | | - * projections (i.e., resultExpressions). Before introducing resultExpressions, we should avoid |
587 | | - * expression-level optimization on aggregateExpressions, which could reference an expression in |
588 | | - * groupingExpressions. |
| 585 | + * Note: Currently, aggregateExpressions is the project list of this Group by operator. Before |
| 586 | + * separating projection from grouping and aggregate, we should avoid expression-level optimization |
| 587 | + * on aggregateExpressions, which could reference an expression in groupingExpressions. |
589 | 588 | * For example, see the rule [[org.apache.spark.sql.catalyst.optimizer.SimplifyExtractValueOps]] |
590 | 589 | */ |
591 | 590 | case class Aggregate( |
|
0 commit comments