Skip to content

Commit fe8e385

Browse files
committed
fix
1 parent a6e7256 commit fe8e385

1 file changed

Lines changed: 6 additions & 7 deletions

File tree

sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/basicLogicalOperators.scala

Lines changed: 6 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -17,11 +17,11 @@
1717

1818
package org.apache.spark.sql.catalyst.plans.logical
1919

20-
import org.apache.spark.sql.catalyst.{AliasIdentifier}
20+
import org.apache.spark.sql.catalyst.AliasIdentifier
2121
import org.apache.spark.sql.catalyst.analysis.{MultiInstanceRelation, NamedRelation}
2222
import org.apache.spark.sql.catalyst.catalog.{CatalogStorageFormat, CatalogTable}
2323
import org.apache.spark.sql.catalyst.expressions._
24-
import org.apache.spark.sql.catalyst.expressions.aggregate.AggregateExpression
24+
import org.apache.spark.sql.catalyst.expressions.aggregate.{AggregateExpression, AggregateFunction}
2525
import org.apache.spark.sql.catalyst.plans._
2626
import org.apache.spark.sql.catalyst.plans.physical.{HashPartitioning, Partitioning, RangePartitioning, RoundRobinPartitioning}
2727
import org.apache.spark.sql.catalyst.util.truncatedString
@@ -580,12 +580,11 @@ case class Range(
580580
*
581581
* @param groupingExpressions expressions for grouping keys
582582
* @param aggregateExpressions expressions for a project list, which could contain
583-
* [[org.apache.spark.sql.catalyst.expressions.aggregate.AggregateFunction]]s.
583+
* [[AggregateFunction]]s.
584584
*
585-
* Note: Currently, aggregateExpressions correspond to both [[AggregateExpression]] and the output
586-
* projections (i.e., resultExpressions). Before introducing resultExpressions, we should avoid
587-
* expression-level optimization on aggregateExpressions, which could reference an expression in
588-
* groupingExpressions.
585+
* Note: Currently, aggregateExpressions is the project list of this Group by operator. Before
586+
* separating projection from grouping and aggregate, we should avoid expression-level optimization
587+
* on aggregateExpressions, which could reference an expression in groupingExpressions.
589588
* For example, see the rule [[org.apache.spark.sql.catalyst.optimizer.SimplifyExtractValueOps]]
590589
*/
591590
case class Aggregate(

0 commit comments

Comments
 (0)