Skip to content

Commit f21ebef

Browse files
committed
CR feedback
1 parent 5e18778 commit f21ebef

1 file changed

Lines changed: 6 additions & 8 deletions

File tree

python/pyspark/ml/feature.py

Lines changed: 6 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -135,9 +135,9 @@ class Bucketizer(JavaTransformer, HasInputCol, HasOutputCol):
135135
"specified will be treated as errors.")
136136

137137
@keyword_only
138-
def __init__(self, splits=None, inputCol=None, outputCol=None, _java_model=None):
138+
def __init__(self, splits=None, inputCol=None, outputCol=None):
139139
"""
140-
__init__(self, splits=None, inputCol=None, outputCol=None, _java_model=None)
140+
__init__(self, splits=None, inputCol=None, outputCol=None)
141141
"""
142142
super(Bucketizer, self).__init__()
143143
self._java_obj = self._new_java_obj("org.apache.spark.ml.feature.Bucketizer", self.uid)
@@ -155,7 +155,6 @@ def __init__(self, splits=None, inputCol=None, outputCol=None, _java_model=None)
155155
"provided to cover all Double values; otherwise, values outside the splits " +
156156
"specified will be treated as errors.")
157157
kwargs = self.__init__._input_kwargs
158-
kwargs.pop("_java_model", None)
159158
self.setParams(**kwargs)
160159

161160
@keyword_only
@@ -1012,8 +1011,8 @@ class QuantileDiscretizer(JavaEstimator, HasInputCol, HasOutputCol):
10121011
-inf
10131012
>>> int(splits[1]*10)
10141013
4
1015-
>>> bucketed = bucketizer.transform(df).collect()
1016-
>>> bucketed[0].buckets
1014+
>>> bucketed = bucketizer.transform(df).head()
1015+
>>> bucketed.buckets
10171016
0.0
10181017
10191018
.. versionadded:: 2.0.0
@@ -1044,7 +1043,7 @@ def __init__(self, numBuckets=2, inputCol=None, outputCol=None):
10441043
def setParams(self, numBuckets=2, inputCol=None, outputCol=None):
10451044
"""
10461045
setParams(self, numBuckets=2, inputCol=None, outputCol=None)
1047-
Set the params for the QuantileDiscertizerBase
1046+
Set the params for the QuantileDiscretizer
10481047
"""
10491048
kwargs = self.setParams._input_kwargs
10501049
return self._set(**kwargs)
@@ -1070,8 +1069,7 @@ def _create_model(self, java_model):
10701069
"""
10711070
return Bucketizer(splits=list(java_model.getSplits()),
10721071
inputCol=self.getInputCol(),
1073-
outputCol=self.getOutputCol(),
1074-
_java_model=java_model)
1072+
outputCol=self.getOutputCol())
10751073

10761074

10771075
@inherit_doc

0 commit comments

Comments
 (0)