address comments

Author: gatorsmile

sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalog.scala

@@ -277,15 +277,15 @@ class SessionCatalog(
    * If the specified table/view is not found in the database then a [[NoSuchTableException]] is
    * thrown.
    */
-  def getTempViewOrPermanentTableMetadata(name: TableIdentifier): CatalogTable = synchronized {
-    val table = formatTableName(name.table)
+  def getTempViewOrPermanentTableMetadata(name: String): CatalogTable = synchronized {
+    val table = formatTableName(name)
     getTempView(table).map { plan =>
       CatalogTable(
         identifier = TableIdentifier(table),
         tableType = CatalogTableType.VIEW,
         storage = CatalogStorageFormat.empty,
         schema = plan.output.toStructType)
-    }.getOrElse(getTableMetadata(name))
+    }.getOrElse(getTableMetadata(TableIdentifier(name)))
   }
 
   /**

sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalogSuite.scala

@@ -444,35 +444,16 @@ class SessionCatalogSuite extends SparkFunSuite {
     assert(!catalog.tableExists(TableIdentifier("view1", Some("default"))))
   }
 
-  test("getTableMetadata and getTempViewOrPermanentTableMetadata on temporary views") {
+  test("getTempViewOrPermanentTableMetadata on temporary views") {
     val catalog = new SessionCatalog(newBasicCatalog())
     val tempTable = Range(1, 10, 2, 10)
-    val m = intercept[AnalysisException] {
-      catalog.getTableMetadata(TableIdentifier("view1"))
-    }.getMessage
-    assert(m.contains("Table or view 'view1' not found in database 'default'"))
-
-    val m2 = intercept[AnalysisException] {
-      catalog.getTableMetadata(TableIdentifier("view1", Some("default")))
-    }.getMessage
-    assert(m2.contains("Table or view 'view1' not found in database 'default'"))
-
     intercept[NoSuchTableException] {
-      catalog.getTempViewOrPermanentTableMetadata(TableIdentifier("view1"))
+      catalog.getTempViewOrPermanentTableMetadata("view1")
     }.getMessage
 
     catalog.createTempView("view1", tempTable, overrideIfExists = false)
-    assert(catalog.getTempViewOrPermanentTableMetadata(TableIdentifier("view1")).identifier ==
+    assert(catalog.getTempViewOrPermanentTableMetadata("view1").identifier ==
       TableIdentifier("view1"), "the temporary view `view1` should exist")
-
-    intercept[NoSuchTableException] {
-      catalog.getTableMetadata(TableIdentifier("view1"))
-    }.getMessage
-
-    val m3 = intercept[AnalysisException] {
-      catalog.getTableMetadata(TableIdentifier("view1", Some("default")))
-    }.getMessage
-    assert(m3.contains("Table or view 'view1' not found in database 'default'"))
   }
 
   test("list tables without pattern") {

sql/core/src/main/scala/org/apache/spark/sql/execution/command/tables.scala

@@ -67,7 +67,7 @@ case class CreateTableLikeCommand(
     val sourceTableDesc = if (sourceTable.database.isDefined) {
       catalog.getTableMetadata(sourceTable)
     } else {
-      catalog.getTempViewOrPermanentTableMetadata(sourceTable)
+      catalog.getTempViewOrPermanentTableMetadata(sourceTable.table)
     }
 
     // Storage format
@@ -605,7 +605,7 @@ case class ShowColumnsCommand(tableName: TableIdentifier) extends RunnableComman
     val table = if (tableName.database.isDefined) {
       catalog.getTableMetadata(tableName)
     } else {
-      catalog.getTempViewOrPermanentTableMetadata(tableName)
+      catalog.getTempViewOrPermanentTableMetadata(tableName.table)
     }
     table.schema.map { c =>
       Row(c.name)

sql/core/src/main/scala/org/apache/spark/sql/internal/CatalogImpl.scala

@@ -154,7 +154,7 @@ class CatalogImpl(sparkSession: SparkSession) extends Catalog {
     val tableMetadata = if (tableIdentifier.database.isDefined) {
       sessionCatalog.getTableMetadata(tableIdentifier)
     } else {
-      sessionCatalog.getTempViewOrPermanentTableMetadata(tableIdentifier)
+      sessionCatalog.getTempViewOrPermanentTableMetadata(tableIdentifier.table)
     }
 
     val partitionColumnNames = tableMetadata.partitionColumnNames.toSet

sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveDDLSuite.scala

@@ -678,8 +678,8 @@ class HiveDDLSuite
           .createTempView(sourceViewName)
         sql(s"CREATE TABLE $targetTabName LIKE $sourceViewName")
 
-        val sourceTable = spark.sessionState.catalog.getTempViewOrPermanentTableMetadata(
-          TableIdentifier(sourceViewName))
+        val sourceTable =
+          spark.sessionState.catalog.getTempViewOrPermanentTableMetadata(sourceViewName)
         val targetTable = spark.sessionState.catalog.getTableMetadata(
           TableIdentifier(targetTabName, Some("default")))