use while loop

yhuai · yhuai · commit ca574e145543 · 2016-08-25T08:35:20.000-07:00
diff --git a/sql/core/src/main/scala/org/apache/spark/sql/execution/aggregate/AggregationIterator.scala b/sql/core/src/main/scala/org/apache/spark/sql/execution/aggregate/AggregationIterator.scala
@@ -247,11 +247,9 @@ abstract class AggregationIterator(
         // Serializes the generic object stored in aggregation buffer
         var i = 0
         while (i < typedImperativeAggregates.length) {
+          typedImperativeAggregates(i).serializeAggregateBufferInPlace(currentBuffer)
           i += 1
         }
-        typedImperativeAggregates.foreach { agg =>
-          agg.serializeAggregateBufferInPlace(currentBuffer)
-        }
         resultProjection(joinedRow(currentGroupingKey, currentBuffer))
       }
     } else {

Original file line number	Diff line number	Diff line change
`@@ -247,11 +247,9 @@ abstract class AggregationIterator(`
`247`	`247`	`// Serializes the generic object stored in aggregation buffer`
`248`	`248`	`var i = 0`
`249`	`249`	`while (i < typedImperativeAggregates.length) {`
	`250`	`+ typedImperativeAggregates(i).serializeAggregateBufferInPlace(currentBuffer)`
`250`	`251`	`i += 1`
`251`	`252`	`}`
`252`		`- typedImperativeAggregates.foreach { agg =>`
`253`		`- agg.serializeAggregateBufferInPlace(currentBuffer)`
`254`		`- }`
`255`	`253`	`resultProjection(joinedRow(currentGroupingKey, currentBuffer))`
`256`	`254`	`}`
`257`	`255`	`} else {`