check to decide if milli transter to micro will out of long range

Author: TJX2014

sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/datetimeExpressions.scala

@@ -814,6 +814,9 @@ abstract class ToTimestamp
         "specified format is '" + o + "'")
   }
 
+  private lazy val minRange = Long.MinValue / scaleFactor
+  private lazy val maxRange = Long.MaxValue / scaleFactor
+
   override def eval(input: InternalRow): Any = {
     val t = left.eval(input)
     if (t == null) {
@@ -856,15 +859,12 @@ abstract class ToTimestamp
           }
         case LongType =>
           val input = t.asInstanceOf[Long]
-          val minRange = Long.MinValue / scaleFactor
-          val maxRange = Long.MaxValue / scaleFactor
           if ( minRange < input && input < maxRange ) {
             Math.multiplyExact(input, scaleFactor.asInstanceOf[Long])
           } else {
             throw new IllegalArgumentException(
-              s"""|input='$input' is not valid,
-                  |which valid range is from $minRange to $maxRange for '$right'""".stripMargin
-            )
+              "input [" + input + "] not from " + minRange + " to "
+                + maxRange + " for format " + right)
           }
       }
     }
@@ -949,7 +949,13 @@ abstract class ToTimestamp
           boolean ${ev.isNull} = ${eval1.isNull};
           $javaType ${ev.value} = ${CodeGenerator.defaultValue(dataType)};
           if (!${ev.isNull}) {
-            ${ev.value} = ${eval1.value} * $scaleFactor;
+            if ( (${minRange}L < ${eval1.value}) && (${eval1.value} < ${maxRange}L) ) {
+              ${ev.value} = ${eval1.value} * $scaleFactor;
+            } else {
+              throw new java.lang.IllegalArgumentException(
+              "input [" + ${eval1.value} + "] not from " + ${minRange}L + " to "
+               + ${maxRange}L + " for format " + "${right.toString}");
+            }
           }""")
     }
   }

sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/DateExpressionsSuite.scala

@@ -1166,18 +1166,22 @@ class DateExpressionsSuite extends SparkFunSuite with ExpressionEvalHelper {
           Literal(-1580184371847123L),
           Literal("micro")), -1580184371847123L)
 
-//      checkEvaluation(
-//        GetTimestamp(Literal(9223372036854776L), Literal("milli")),
-//        "input='9223372036854776' is not valid,\n" +
-//          "which valid range is from -9223372036854775 to 9223372036854775 for 'milli'"
-//      )
-
+//      out of range check
       checkExceptionInExpression[IllegalArgumentException](
         GetTimestamp(Literal(9223372036854776L), Literal("milli")),
-        "input='9223372036854776' is not valid,\n" +
-          "which valid range is from -9223372036854775 to 9223372036854775 for 'milli'"
+        "input [9223372036854776] not from " +
+          "-9223372036854775 to 9223372036854775 for format milli"
       )
 
+      checkExceptionInExpression[IllegalArgumentException](
+        GetTimestamp(Literal(-9223372036854776L), Literal("milli")),
+        "input [-9223372036854776] not from " +
+          "-9223372036854775 to 9223372036854775 for format milli"
+      )
+
+//      micro range could not out of range
+
+//      illegal format check
       checkExceptionInExpression[IllegalArgumentException](
         GetTimestamp(
           Literal(1580184371847123L),