Skip to content

Commit adc2b59

Browse files
committed
refactor unit test
1 parent b183cba commit adc2b59

2 files changed

Lines changed: 24 additions & 14 deletions

File tree

sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/analysis/AnalysisSuite.scala

Lines changed: 24 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ import org.apache.log4j.Level
2626
import org.scalatest.Matchers
2727

2828
import org.apache.spark.api.python.PythonEvalType
29-
import org.apache.spark.sql.catalyst.TableIdentifier
29+
import org.apache.spark.sql.catalyst.{AliasIdentifier, TableIdentifier}
3030
import org.apache.spark.sql.catalyst.catalog.{CatalogStorageFormat, CatalogTable, CatalogTableType, InMemoryCatalog, SessionCatalog}
3131
import org.apache.spark.sql.catalyst.dsl.expressions._
3232
import org.apache.spark.sql.catalyst.dsl.plans._
@@ -895,4 +895,27 @@ class AnalysisSuite extends AnalysisTest with Matchers {
895895
assertAnalysisError(testRelation2.select(RowNumber() + 1),
896896
Seq("Window function row_number() requires an OVER clause."))
897897
}
898+
899+
test("SPARK-32237: Hint in CTE") {
900+
val plan = With(
901+
Project(
902+
Seq(UnresolvedAttribute("cte.a")),
903+
UnresolvedRelation(TableIdentifier("cte"))
904+
),
905+
Seq(
906+
(
907+
"cte",
908+
SubqueryAlias(
909+
AliasIdentifier("cte"),
910+
UnresolvedHint(
911+
"REPARTITION",
912+
Seq(Literal(3)),
913+
Project(testRelation.output, testRelation)
914+
)
915+
)
916+
)
917+
)
918+
)
919+
assertAnalysisSuccess(plan)
920+
}
898921
}

sql/core/src/test/scala/org/apache/spark/sql/connector/DataSourceV2SQLSuite.scala

Lines changed: 0 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -756,19 +756,6 @@ class DataSourceV2SQLSuite
756756
}
757757
}
758758

759-
test("SPARK-32237: Hint in CTE") {
760-
val t1 = "testcat.ns1.ns2.tbl"
761-
withTable(t1) {
762-
sql(s"CREATE TABLE $t1 USING foo AS SELECT id, data FROM source")
763-
checkAnswer(
764-
sql(s"""
765-
|WITH cte AS (SELECT /*+ REPARTITION(3) */ * FROM $t1)
766-
|SELECT * FROM cte
767-
""".stripMargin),
768-
spark.table("source"))
769-
}
770-
}
771-
772759
test("Relation: view text") {
773760
val t1 = "testcat.ns1.ns2.tbl"
774761
withTable(t1) {

0 commit comments

Comments
 (0)