Skip to content

Commit a854316

Browse files
committed
[SPARK-29873][SQL] set operations should not escape when regen golden file with --SET --import both specified
1 parent f77c10d commit a854316

7 files changed

Lines changed: 70 additions & 2 deletions

File tree

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,2 +1,5 @@
11
--- malformed interval literal with ansi mode
2+
-- SET spark.abc=xyz
23
--import literals.sql
4+
5+
SET spark.abc;
Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,3 @@
1+
set spark.abc;
2+
set spark.abc=efg;
3+
set spark.abc;
Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,2 @@
1+
--SET spark.abc=xyz;
2+
--import set-cmd.sql

sql/core/src/test/resources/sql-tests/results/ansi/literals.sql.out

Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
-- Automatically generated by SQLQueryTestSuite
2-
-- Number of queries: 48
2+
-- Number of queries: 49
33

44

55
-- !query 0
@@ -472,3 +472,11 @@ select +integer '7'
472472
struct<7:int>
473473
-- !query 47 output
474474
7
475+
476+
477+
-- !query 48
478+
SET spark.abc
479+
-- !query 48 schema
480+
struct<key:string,value:string>
481+
-- !query 48 output
482+
spark.abc <undefined>
Lines changed: 26 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,26 @@
1+
-- Automatically generated by SQLQueryTestSuite
2+
-- Number of queries: 3
3+
4+
5+
-- !query 0
6+
set spark.abc
7+
-- !query 0 schema
8+
struct<key:string,value:string>
9+
-- !query 0 output
10+
spark.abc <undefined>
11+
12+
13+
-- !query 1
14+
set spark.abc=efg
15+
-- !query 1 schema
16+
struct<key:string,value:string>
17+
-- !query 1 output
18+
spark.abc efg
19+
20+
21+
-- !query 2
22+
set spark.abc
23+
-- !query 2 schema
24+
struct<key:string,value:string>
25+
-- !query 2 output
26+
spark.abc efg
Lines changed: 26 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,26 @@
1+
-- Automatically generated by SQLQueryTestSuite
2+
-- Number of queries: 3
3+
4+
5+
-- !query 0
6+
set spark.abc
7+
-- !query 0 schema
8+
struct<key:string,value:string>
9+
-- !query 0 output
10+
spark.abc xyz;
11+
12+
13+
-- !query 1
14+
set spark.abc=efg
15+
-- !query 1 schema
16+
struct<key:string,value:string>
17+
-- !query 1 output
18+
spark.abc efg
19+
20+
21+
-- !query 2
22+
set spark.abc
23+
-- !query 2 schema
24+
struct<key:string,value:string>
25+
-- !query 2 output
26+
spark.abc efg

sql/core/src/test/scala/org/apache/spark/sql/SQLQueryTestSuite.scala

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -285,7 +285,7 @@ class SQLQueryTestSuite extends QueryTest with SharedSparkSession {
285285

286286
// When we are regenerating the golden files, we don't need to set any config as they
287287
// all need to return the same result
288-
if (regenerateGoldenFiles || !isTestWithConfigSets) {
288+
if ((regenerateGoldenFiles && importedTestCaseName.isEmpty) || !isTestWithConfigSets) {
289289
runQueries(queries, testCase, None)
290290
} else {
291291
val configSets = {

0 commit comments

Comments
 (0)