Skip to content

Commit a316760

Browse files
committed
remove vars, update docs
1 parent ad17a02 commit a316760

2 files changed

Lines changed: 4 additions & 6 deletions

File tree

resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/Config.scala

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -100,13 +100,13 @@ private[spark] object Config extends Logging {
100100

101101
val DRIVER_CLIENT_REQUEST_TIMEOUT =
102102
ConfigBuilder("spark.kubernetes.driver.requestTimeout")
103-
.doc("request timeout to be used in milliseconds for requesting executors")
103+
.doc("request timeout to be used in milliseconds for driver to request executors")
104104
.intConf
105105
.createWithDefault(10000)
106106

107107
val DRIVER_CLIENT_CONNECTION_TIMEOUT =
108108
ConfigBuilder("spark.kubernetes.driver.connectionTimeout")
109-
.doc("connection timeout to be used in milliseconds for requesting executors")
109+
.doc("connection timeout to be used in milliseconds for driver to request executors")
110110
.intConf
111111
.createWithDefault(10000)
112112

resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/SparkKubernetesClientFactory.scala

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -67,8 +67,6 @@ private[spark] object SparkKubernetesClientFactory extends Logging {
6767
.getOption(s"$kubernetesAuthConfPrefix.$CLIENT_KEY_FILE_CONF_SUFFIX")
6868
val clientCertFile = sparkConf
6969
.getOption(s"$kubernetesAuthConfPrefix.$CLIENT_CERT_FILE_CONF_SUFFIX")
70-
val requestTimeout = clientType.requestTimeout(sparkConf)
71-
val connectionTimeout = clientType.connectionTimeout(sparkConf)
7270
val dispatcher = new Dispatcher(
7371
ThreadUtils.newDaemonCachedThreadPool("kubernetes-dispatcher"))
7472

@@ -85,8 +83,8 @@ private[spark] object SparkKubernetesClientFactory extends Logging {
8583
.withApiVersion("v1")
8684
.withMasterUrl(master)
8785
.withWebsocketPingInterval(0)
88-
.withRequestTimeout(requestTimeout)
89-
.withConnectionTimeout(connectionTimeout)
86+
.withRequestTimeout(clientType.requestTimeout(sparkConf))
87+
.withConnectionTimeout(clientType.connectionTimeout(sparkConf))
9088
.withOption(oauthTokenValue) {
9189
(token, configBuilder) => configBuilder.withOauthToken(token)
9290
}.withOption(oauthTokenFile) {

0 commit comments

Comments
 (0)